TheCloneArmy/crater
1
0
Fork 1
mirror of https://github.com/crater-invoice/crater.git synced 2025-10-27 11:41:09 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix condition

Browse Source
This commit is contained in:
harshjagad20
2022-03-03 15:10:53 +05:30
parent 388d00241b
commit 25c43ab4d2
5 changed files with 24 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Http/Controllers/V1/Admin/Settings/CompanyCurrencyCheckTransactionsController.php
View File

@ -4,8 +4,6 @@ namespace Crater\Http\Controllers\V1\Admin\Settings;
use Crater\Http\Controllers\Controller;
use Crater\Models\Company;
use Crater\Models\CompanySetting;
use Crater\Models\Currency;
use Illuminate\Http\Request;
class CompanyCurrencyCheckTransactionsController extends Controller
@ -18,13 +16,11 @@ class CompanyCurrencyCheckTransactionsController extends Controller
*/
public function __invoke(Request $request)
{
$this->authorize('manage company', Company::find($request->header('company')));
$company = Company::find($request->header('company'));
$companyCurrency = CompanySetting::getSetting('currency', $request->header('company'));
$this->authorize('manage company', $company);
$currency = Currency::find((int)$companyCurrency);
if ($currency->checkTransactions()) {
if ($company->hasTransactions()) {
return response()->json([
'success' => false,
]);

8
app/Http/Controllers/V1/Admin/Settings/UpdateCompanySettingsController.php
View File

@ -6,7 +6,6 @@ use Crater\Http\Controllers\Controller;
use Crater\Http\Requests\UpdateSettingsRequest;
use Crater\Models\Company;
use Crater\Models\CompanySetting;
use Crater\Models\Currency;
class UpdateCompanySettingsController extends Controller
{
@ -18,14 +17,13 @@ class UpdateCompanySettingsController extends Controller
*/
public function __invoke(UpdateSettingsRequest $request)
{
$this->authorize('manage company', Company::find($request->header('company')));
$company = Company::find($request->header('company'));
$this->authorize('manage company', $company);
$companyCurrency = CompanySetting::getSetting('currency', $request->header('company'));
$data = $request->settings;
$currency = Currency::find((int)$companyCurrency);
if ($companyCurrency !== $data['currency'] && $currency->checkTransactions()) {
if ($companyCurrency !== $data['currency'] && $company->hasTransactions()) {
return response()->json([
'success' => false,
'message' => 'You cannot change currency once transaction is created.'