Implement PHP CS Fixer and a coding standard to follow (#471)

* Create PHP CS Fixer config and add to CI workflow

* Run php cs fixer on project

* Add newline at end of file

* Update to use PHP CS Fixer v3

* Run v3 config on project

* Run seperate config in CI
This commit is contained in:
Mwikala Kangwa
2021-05-21 12:57:51 +01:00
committed by GitHub
parent 633cad9b89
commit 9e98a96d61
316 changed files with 4715 additions and 3195 deletions

View File

@ -2,13 +2,12 @@
namespace Crater\Http\Controllers\V1\General;
use Crater\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Crater\Models\Currency;
use Crater\Models\Country;
use Auth;
use Crater\Http\Controllers\Controller;
use Crater\Models\CompanySetting;
use Crater\Models\CustomField;
use Crater\Models\Country;
use Crater\Models\Currency;
use Illuminate\Http\Request;
class BootstrapController extends Controller
{
@ -29,7 +28,7 @@ class BootstrapController extends Controller
'carbon_date_format',
'fiscal_year',
'time_zone',
'currency'
'currency',
];
$settings = CompanySetting::getSettings($settings, $user->company_id);
@ -46,7 +45,7 @@ class BootstrapController extends Controller
'moment_date_format' => $settings['moment_date_format'],
'carbon_date_format' => $settings['carbon_date_format'],
'fiscal_year' => $settings['fiscal_year'],
'time_zone' => $settings['time_zone']
'time_zone' => $settings['time_zone'],
]);
}
}

View File

@ -2,8 +2,8 @@
namespace Crater\Http\Controllers\V1\General;
use Crater\Models\Country;
use Crater\Http\Controllers\Controller;
use Crater\Models\Country;
use Illuminate\Http\Request;
class CountriesController extends Controller
@ -17,7 +17,7 @@ class CountriesController extends Controller
public function __invoke(Request $request)
{
return response()->json([
'countries' => Country::all()
'countries' => Country::all(),
]);
}
}

View File

@ -2,8 +2,8 @@
namespace Crater\Http\Controllers\V1\General;
use Crater\Models\Currency;
use Crater\Http\Controllers\Controller;
use Crater\Models\Currency;
use Illuminate\Http\Request;
class CurrenciesController extends Controller
@ -19,7 +19,7 @@ class CurrenciesController extends Controller
$currencies = Currency::latest()->get();
return response()->json([
'currencies' => $currencies
'currencies' => $currencies,
]);
}
}

View File

@ -17,7 +17,7 @@ class DateFormatsController extends Controller
public function __invoke(Request $request)
{
return response()->json([
'date_formats' => DateFormatter::get_list()
'date_formats' => DateFormatter::get_list(),
]);
}
}

View File

@ -16,7 +16,7 @@ class FiscalYearsController extends Controller
public function __invoke(Request $request)
{
return response()->json([
'fiscal_years' => config('crater.fiscal_years')
'fiscal_years' => config('crater.fiscal_years'),
]);
}
}

View File

@ -16,7 +16,7 @@ class LanguagesController extends Controller
public function __invoke(Request $request)
{
return response()->json([
'languages' => config('crater.languages')
'languages' => config('crater.languages'),
]);
}
}

View File

@ -2,11 +2,11 @@
namespace Crater\Http\Controllers\V1\General;
use Crater\Models\Invoice;
use Crater\Models\Estimate;
use Crater\Models\Payment;
use Crater\Models\CompanySetting;
use Crater\Http\Controllers\Controller;
use Crater\Models\CompanySetting;
use Crater\Models\Estimate;
use Crater\Models\Invoice;
use Crater\Models\Payment;
use Illuminate\Http\Request;
class NextNumberController extends Controller
@ -21,7 +21,7 @@ class NextNumberController extends Controller
{
$key = $request->key;
$val = $key . '_prefix';
$val = $key.'_prefix';
$prefix = CompanySetting::getSetting(
$val,
@ -33,14 +33,17 @@ class NextNumberController extends Controller
switch ($key) {
case 'invoice':
$nextNumber = Invoice::getNextInvoiceNumber($prefix);
break;
case 'estimate':
$nextNumber = Estimate::getNextEstimateNumber($prefix);
break;
case 'payment':
$nextNumber = Payment::getNextPaymentNumber($prefix);
break;
default:
@ -49,7 +52,7 @@ class NextNumberController extends Controller
return response()->json([
'nextNumber' => $nextNumber,
'prefix' => $prefix
'prefix' => $prefix,
]);
}
}

View File

@ -23,7 +23,7 @@ class NotesController extends Controller
->paginate($limit);
return response()->json([
'notes' => $notes
'notes' => $notes,
]);
}
@ -38,7 +38,7 @@ class NotesController extends Controller
$note = Note::create($request->validated());
return response()->json([
'note' => $note
'note' => $note,
]);
}
@ -51,7 +51,7 @@ class NotesController extends Controller
public function show(Note $note)
{
return response()->json([
'note' => $note
'note' => $note,
]);
}
@ -67,7 +67,7 @@ class NotesController extends Controller
$note->update($request->validated());
return response()->json([
'note' => $note
'note' => $note,
]);
}
@ -82,7 +82,7 @@ class NotesController extends Controller
$note->delete();
return response()->json([
'success' => true
'success' => true,
]);
}
}

View File

@ -31,7 +31,7 @@ class SearchController extends Controller
return response()->json([
'customers' => $customers,
'users' => $users ?? []
'users' => $users ?? [],
]);
}
}

View File

@ -17,7 +17,7 @@ class TimezonesController extends Controller
public function __invoke(Request $request)
{
return response()->json([
'time_zones' => TimeZones::get_list()
'time_zones' => TimeZones::get_list(),
]);
}
}