Implement PHP CS Fixer and a coding standard to follow (#471)

* Create PHP CS Fixer config and add to CI workflow

* Run php cs fixer on project

* Add newline at end of file

* Update to use PHP CS Fixer v3

* Run v3 config on project

* Run seperate config in CI
This commit is contained in:
Mwikala Kangwa
2021-05-21 12:57:51 +01:00
committed by GitHub
parent 633cad9b89
commit 9e98a96d61
316 changed files with 4715 additions and 3195 deletions

View File

@ -2,9 +2,9 @@
namespace Crater\Http\Controllers\V1\Invoice;
use Illuminate\Http\Request;
use Crater\Http\Controllers\Controller;
use Crater\Models\Invoice;
use Illuminate\Http\Request;
class ChangeInvoiceStatusController extends Controller
{
@ -14,8 +14,8 @@ class ChangeInvoiceStatusController extends Controller
* @param \Illuminate\Http\Request $request
* @return \Illuminate\Http\JsonResponse
*/
public function __invoke(Request $request, Invoice $invoice)
{
public function __invoke(Request $request, Invoice $invoice)
{
if ($request->status == Invoice::STATUS_SENT) {
$invoice->status = Invoice::STATUS_SENT;
$invoice->sent = true;
@ -28,7 +28,7 @@ class ChangeInvoiceStatusController extends Controller
}
return response()->json([
'success' => true
'success' => true,
]);
}
}

View File

@ -2,11 +2,11 @@
namespace Crater\Http\Controllers\V1\Invoice;
use Illuminate\Http\Request;
use Crater\Http\Controllers\Controller;
use Crater\Models\Invoice;
use Carbon\Carbon;
use Crater\Http\Controllers\Controller;
use Crater\Models\CompanySetting;
use Crater\Models\Invoice;
use Illuminate\Http\Request;
class CloneInvoiceController extends Controller
{
@ -28,7 +28,7 @@ class CloneInvoiceController extends Controller
$newInvoice = Invoice::create([
'invoice_date' => $date->format('Y-m-d'),
'due_date' => $date->format('Y-m-d'),
'invoice_number' => $invoice_prefix . "-" . Invoice::getNextInvoiceNumber($invoice_prefix),
'invoice_number' => $invoice_prefix."-".Invoice::getNextInvoiceNumber($invoice_prefix),
'reference_number' => $invoice->reference_number,
'user_id' => $invoice->user_id,
'company_id' => $request->header('company'),
@ -45,7 +45,7 @@ class CloneInvoiceController extends Controller
'discount_per_item' => $invoice->discount_per_item,
'tax' => $invoice->tax,
'notes' => $invoice->notes,
'unique_hash' => str_random(60)
'unique_hash' => str_random(60),
]);
$invoice->load('items.taxes');
@ -79,13 +79,13 @@ class CloneInvoiceController extends Controller
'items',
'user',
'invoiceTemplate',
'taxes'
'taxes',
])
->find($newInvoice->id);
return response()->json([
'invoice' => $newInvoice,
'success' => true
'success' => true,
]);
}
}

View File

@ -19,7 +19,7 @@ class InvoiceTemplatesController extends Controller
$invoiceTemplates = InvoiceTemplate::all();
return response()->json([
'invoiceTemplates' => $invoiceTemplates
'invoiceTemplates' => $invoiceTemplates,
]);
}
}

View File

@ -2,12 +2,12 @@
namespace Crater\Http\Controllers\V1\Invoice;
use Illuminate\Http\Request;
use Crater\Http\Requests;
use Crater\Models\Invoice;
use Crater\Http\Controllers\Controller;
use Crater\Http\Requests;
use Crater\Http\Requests\DeleteInvoiceRequest;
use Crater\Jobs\GenerateInvoicePdfJob;
use Crater\Models\Invoice;
use Illuminate\Http\Request;
class InvoicesController extends Controller
{
@ -41,7 +41,7 @@ class InvoicesController extends Controller
return response()->json([
'invoices' => $invoices,
'invoiceTotalCount' => Invoice::count()
'invoiceTotalCount' => Invoice::count(),
]);
}
@ -62,7 +62,7 @@ class InvoicesController extends Controller
GenerateInvoicePdfJob::dispatch($invoice);
return response()->json([
'invoice' => $invoice
'invoice' => $invoice,
]);
}
@ -80,7 +80,7 @@ class InvoicesController extends Controller
'user',
'invoiceTemplate',
'taxes.taxType',
'fields.customField'
'fields.customField',
]);
$siteData = [
@ -107,7 +107,7 @@ class InvoicesController extends Controller
return response()->json([
'invoice' => $invoice,
'success' => true
'success' => true,
]);
}
@ -122,7 +122,7 @@ class InvoicesController extends Controller
Invoice::destroy($request->ids);
return response()->json([
'success' => true
'success' => true,
]);
}
}

View File

@ -3,8 +3,8 @@
namespace Crater\Http\Controllers\V1\Invoice;
use Crater\Http\Controllers\Controller;
use Crater\Models\Invoice;
use Crater\Http\Requests\SendInvoiceRequest;
use Crater\Models\Invoice;
class SendInvoiceController extends Controller
{
@ -19,7 +19,7 @@ class SendInvoiceController extends Controller
$invoice->send($request->all());
return response()->json([
'success' => true
'success' => true,
]);
}
}