Implement PHP CS Fixer and a coding standard to follow (#471)

* Create PHP CS Fixer config and add to CI workflow

* Run php cs fixer on project

* Add newline at end of file

* Update to use PHP CS Fixer v3

* Run v3 config on project

* Run seperate config in CI
This commit is contained in:
Mwikala Kangwa
2021-05-21 12:57:51 +01:00
committed by GitHub
parent 633cad9b89
commit 9e98a96d61
316 changed files with 4715 additions and 3195 deletions

View File

@ -3,11 +3,11 @@
namespace Crater\Http\Controllers\V1\Item;
use Crater\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Crater\Http\Requests;
use Crater\Http\Requests\DeleteItemsRequest;
use Crater\Models\Item;
use Crater\Models\TaxType;
use Illuminate\Http\Request;
class ItemsController extends Controller
{
@ -29,7 +29,7 @@ class ItemsController extends Controller
'unit_id',
'item_id',
'orderByField',
'orderBy'
'orderBy',
]))
->whereCompany($request->header('company'))
->select('items.*', 'units.name as unit_name')
@ -39,7 +39,7 @@ class ItemsController extends Controller
return response()->json([
'items' => $items,
'taxTypes' => TaxType::latest()->get(),
'itemTotalCount' => Item::count()
'itemTotalCount' => Item::count(),
]);
}
@ -54,7 +54,7 @@ class ItemsController extends Controller
$item = Item::createItem($request);
return response()->json([
'item' => $item
'item' => $item,
]);
}
@ -69,7 +69,7 @@ class ItemsController extends Controller
$item->load('taxes');
return response()->json([
'item' => $item
'item' => $item,
]);
}
@ -85,7 +85,7 @@ class ItemsController extends Controller
$item = $item->updateItem($request);
return response()->json([
'item' => $item
'item' => $item,
]);
}
@ -100,7 +100,7 @@ class ItemsController extends Controller
Item::destroy($request->ids);
return response()->json([
'success' => true
'success' => true,
]);
}
}

View File

@ -2,10 +2,10 @@
namespace Crater\Http\Controllers\V1\Item;
use Crater\Http\Controllers\Controller;
use Crater\Http\Requests\UnitRequest;
use Crater\Models\Unit;
use Illuminate\Http\Request;
use Crater\Http\Requests\UnitRequest;
use Crater\Http\Controllers\Controller;
class UnitsController extends Controller
{
@ -20,13 +20,13 @@ class UnitsController extends Controller
$units = Unit::whereCompany($request->header('company'))
->applyFilters($request->only([
'unit_id'
'unit_id',
]))
->latest()
->paginateData($limit);
return response()->json([
'units' => $units
'units' => $units,
]);
}
@ -53,7 +53,7 @@ class UnitsController extends Controller
$unit = Unit::create($data);
return response()->json([
'unit' => $unit
'unit' => $unit,
]);
}
@ -66,7 +66,7 @@ class UnitsController extends Controller
public function show(Unit $unit)
{
return response()->json([
'unit' => $unit
'unit' => $unit,
]);
}
@ -82,7 +82,7 @@ class UnitsController extends Controller
$unit->update($request->validated());
return response()->json([
'unit' => $unit
'unit' => $unit,
]);
}
@ -96,14 +96,14 @@ class UnitsController extends Controller
{
if ($unit->items()->exists()) {
return response()->json([
'error' => 'items_attached'
'error' => 'items_attached',
]);
}
$unit->delete();
return response()->json([
'success' => 'Unit deleted successfully'
'success' => 'Unit deleted successfully',
]);
}
}