Implement PHP CS Fixer and a coding standard to follow (#471)

* Create PHP CS Fixer config and add to CI workflow

* Run php cs fixer on project

* Add newline at end of file

* Update to use PHP CS Fixer v3

* Run v3 config on project

* Run seperate config in CI

routes/api.php

@@ -2,7 +2,6 @@
 
 use Crater\Http\Controllers\AppVersionController;
 use Crater\Http\Controllers\V1\Auth\ForgotPasswordController;
-use Crater\Http\Controllers\V1\Auth\IsRegisteredController;
 use Crater\Http\Controllers\V1\Auth\ResetPasswordController;
 use Crater\Http\Controllers\V1\Backup\BackupsController;
 use Crater\Http\Controllers\V1\Backup\DownloadBackupController;
@@ -22,34 +21,34 @@ use Crater\Http\Controllers\V1\Expense\UploadReceiptController;
 use Crater\Http\Controllers\V1\General\BootstrapController;
 use Crater\Http\Controllers\V1\General\CountriesController;
 use Crater\Http\Controllers\V1\General\CurrenciesController;
-use Crater\Http\Controllers\V1\General\NextNumberController;
 use Crater\Http\Controllers\V1\General\DateFormatsController;
 use Crater\Http\Controllers\V1\General\FiscalYearsController;
 use Crater\Http\Controllers\V1\General\LanguagesController;
+use Crater\Http\Controllers\V1\General\NextNumberController;
 use Crater\Http\Controllers\V1\General\NotesController;
 use Crater\Http\Controllers\V1\General\SearchController;
 use Crater\Http\Controllers\V1\General\TimezonesController;
 use Crater\Http\Controllers\V1\Invoice\ChangeInvoiceStatusController;
 use Crater\Http\Controllers\V1\Invoice\CloneInvoiceController;
 use Crater\Http\Controllers\V1\Invoice\InvoicesController;
-use Crater\Http\Controllers\V1\Invoice\SendInvoiceController;
 use Crater\Http\Controllers\V1\Invoice\InvoiceTemplatesController;
+use Crater\Http\Controllers\V1\Invoice\SendInvoiceController;
 use Crater\Http\Controllers\V1\Item\ItemsController;
 use Crater\Http\Controllers\V1\Item\UnitsController;
 use Crater\Http\Controllers\V1\Mobile\AuthController;
 use Crater\Http\Controllers\V1\Onboarding\DatabaseConfigurationController;
-use Crater\Http\Controllers\V1\Settings\MailConfigurationController;
+use Crater\Http\Controllers\V1\Onboarding\FinishController;
+use Crater\Http\Controllers\V1\Onboarding\OnboardingWizardController;
 use Crater\Http\Controllers\V1\Onboarding\PermissionsController;
 use Crater\Http\Controllers\V1\Onboarding\RequirementsController;
-use Crater\Http\Controllers\V1\Onboarding\OnboardingWizardController;
-use Crater\Http\Controllers\V1\Onboarding\FinishController;
-use Crater\Http\Controllers\V1\Payment\PaymentsController;
 use Crater\Http\Controllers\V1\Payment\PaymentMethodsController;
+use Crater\Http\Controllers\V1\Payment\PaymentsController;
 use Crater\Http\Controllers\V1\Payment\SendPaymentController;
 use Crater\Http\Controllers\V1\Settings\CompanyController;
 use Crater\Http\Controllers\V1\Settings\DiskController;
 use Crater\Http\Controllers\V1\Settings\GetCompanySettingsController;
 use Crater\Http\Controllers\V1\Settings\GetUserSettingsController;
+use Crater\Http\Controllers\V1\Settings\MailConfigurationController;
 use Crater\Http\Controllers\V1\Settings\TaxTypesController;
 use Crater\Http\Controllers\V1\Settings\UpdateCompanySettingsController;
 use Crater\Http\Controllers\V1\Settings\UpdateUserSettingsController;
@@ -80,7 +79,7 @@ use Illuminate\Support\Facades\Route;
 
 Route::get('ping', function () {
     return response()->json([
-        'success' => 'crater-self-hosted'
+        'success' => 'crater-self-hosted',
     ]);
 })->name('ping');
 
@@ -100,17 +99,16 @@ Route::prefix('/v1')->group(function () {
     //----------------------------------
 
     Route::group(['prefix' => 'auth'], function () {
-
         Route::post('login', [AuthController::class, 'login']);
 
         Route::post('logout', [AuthController::class, 'logout'])->middleware('auth:sanctum');
 
         // Send reset password mail
-        Route::post('password/email', [ForgotPasswordController::class, 'sendResetLinkEmail'])->middleware("throttle:10,2");;
+        Route::post('password/email', [ForgotPasswordController::class, 'sendResetLinkEmail'])->middleware("throttle:10,2");
+        ;
 
         // handle reset password form process
         Route::post('reset/password', [ResetPasswordController::class, 'reset']);
-
     });
 
 
@@ -124,7 +122,6 @@ Route::prefix('/v1')->group(function () {
     //----------------------------------
 
     Route::middleware(['redirect-if-installed'])->group(function () {
-
         Route::get('/onboarding/wizard-step', [OnboardingWizardController::class, 'getStep']);
 
         Route::post('/onboarding/wizard-step', [OnboardingWizardController::class, 'updateStep']);
@@ -138,7 +135,6 @@ Route::prefix('/v1')->group(function () {
         Route::get('/onboarding/database/config', [DatabaseConfigurationController::class, 'getDatabaseEnvironment']);
 
         Route::post('/onboarding/finish', FinishController::class);
-
     });
 
 
@@ -342,6 +338,5 @@ Route::prefix('/v1')->group(function () {
         Route::post('/users/delete', [UsersController::class, 'delete']);
 
         Route::apiResource('/users', UsersController::class);
-
     });
 });

routes/channels.php

@@ -1,14 +1,13 @@
 <?php
 
 use Illuminate\Support\Facades\Broadcast;
-use Crater\Models\User;
 
-Broadcast::channel('conversation.{cid}', function ($user,$cid) {
+Broadcast::channel('conversation.{cid}', function ($user, $cid) {
     return true; //(int) $user->conversation_id === (int) $cid
 });
 
 Broadcast::channel('user.{uid}', function () {
-  return true; //(int) $user->conversation_id === (int) $cid
+    return true; //(int) $user->conversation_id === (int) $cid
 });
 
 Broadcast::channel('company.{companyId}', function ($user, $companyId) {

routes/web.php

@@ -45,7 +45,6 @@ Route::prefix('reports')->group(function () {
     // report for profit and loss
     //----------------------------------
     Route::get('/profit-loss/{hash}', ProfitLossReportController::class);
-
 });