Implement PHP CS Fixer and a coding standard to follow (#471)

* Create PHP CS Fixer config and add to CI workflow

* Run php cs fixer on project

* Add newline at end of file

* Update to use PHP CS Fixer v3

* Run v3 config on project

* Run seperate config in CI
This commit is contained in:
Mwikala Kangwa
2021-05-21 12:57:51 +01:00
committed by GitHub
parent 633cad9b89
commit 9e98a96d61
316 changed files with 4715 additions and 3195 deletions

View File

@ -3,9 +3,10 @@
use Crater\Http\Requests\CustomFieldRequest;
test('custom field request validation rules', function () {
$request = new CustomFieldRequest;
$request = new CustomFieldRequest();
$this->assertEquals([
$this->assertEquals(
[
'name' => 'required',
'label' => 'required',
'model_type' => 'required',
@ -20,7 +21,7 @@ test('custom field request validation rules', function () {
});
test('custom field request authorize', function () {
$request = new CustomFieldRequest;
$request = new CustomFieldRequest();
$this->assertTrue($request->authorize());
});

View File

@ -3,57 +3,59 @@
use Crater\Http\Requests\CustomerRequest;
test('customer request post validation rules', function () {
$request = new CustomerRequest;
$request = new CustomerRequest();
$request->setMethod('POST');
$this->assertEquals([
$this->assertEquals(
[
'name' => [
'required'
'required',
],
'addresses.*.address_street_1' => [
'max:255'
'max:255',
],
'addresses.*.address_street_2' => [
'max:255'
'max:255',
],
'email' => [
'email',
'nullable',
'unique:users,email',
]
],
],
$request->rules()
);
});
test('customer request put validation rules', function () {
$request = new CustomerRequest;
$request = new CustomerRequest();
$request->setMethod('PUT');
$this->assertEquals([
$this->assertEquals(
[
'name' => [
'required'
'required',
],
'addresses.*.address_street_1' => [
'max:255'
'max:255',
],
'addresses.*.address_street_2' => [
'max:255'
'max:255',
],
'email' => [
'email',
'nullable',
'unique:users,email',
]
],
],
$request->rules()
);
});
test('customer request authorize', function () {
$request = new CustomerRequest;
$request = new CustomerRequest();
$this->assertTrue($request->authorize());
});

View File

@ -1,63 +1,64 @@
<?php
use Crater\Models\Estimate;
use Crater\Http\Requests\EstimatesRequest;
use Crater\Models\Estimate;
use Crater\Rules\UniqueNumber;
test('estimate request validation rules', function () {
$request = new EstimatesRequest;
$request = new EstimatesRequest();
$this->assertEquals([
$this->assertEquals(
[
'estimate_date' => [
'required'
'required',
],
'expiry_date' => [
'required'
'required',
],
'user_id' => [
'required'
'required',
],
'discount' => [
'required'
'required',
],
'discount_val' => [
'required'
'required',
],
'sub_total' => [
'required'
'required',
],
'total' => [
'required'
'required',
],
'tax' => [
'required'
'required',
],
'estimate_template_id' => [
'required'
'required',
],
'items' => [
'required',
'array'
'array',
],
'items.*.description' => [
'max:255'
'max:255',
],
'items.*' => [
'required',
'max:255'
'max:255',
],
'items.*.name' => [
'required'
'required',
],
'items.*.quantity' => [
'required'
'required',
],
'items.*.price' => [
'required'
'required',
],
'estimate_number' => [
'required',
new UniqueNumber(Estimate::class)
new UniqueNumber(Estimate::class),
],
],
$request->rules()
@ -65,7 +66,7 @@ test('estimate request validation rules', function () {
});
test('estimate request authorize', function () {
$request = new EstimatesRequest;
$request = new EstimatesRequest();
$this->assertTrue($request->authorize());
});

View File

@ -3,22 +3,23 @@
use Crater\Http\Requests\ExpenseCategoryRequest;
test('expense category request validation rules', function () {
$request = new ExpenseCategoryRequest;
$request = new ExpenseCategoryRequest();
$this->assertEquals([
$this->assertEquals(
[
'name' => [
'required'
'required',
],
'description' => [
'nullable'
]
'nullable',
],
],
$request->rules()
);
});
test('expense category request authorize', function () {
$request = new ExpenseCategoryRequest;
$request = new ExpenseCategoryRequest();
$this->assertTrue($request->authorize());
});

View File

@ -3,31 +3,32 @@
use Crater\Http\Requests\ExpenseRequest;
test('expense request validation rules', function () {
$request = new ExpenseRequest;
$request = new ExpenseRequest();
$this->assertEquals([
$this->assertEquals(
[
'expense_date' => [
'required'
'required',
],
'expense_category_id' => [
'required'
'required',
],
'amount' => [
'required'
'required',
],
'user_id' => [
'nullable'
'nullable',
],
'notes' => [
'nullable'
]
'nullable',
],
],
$request->rules()
);
});
test('expense request authorize', function () {
$request = new ExpenseRequest;
$request = new ExpenseRequest();
$this->assertTrue($request->authorize());
});

View File

@ -3,16 +3,17 @@
use Crater\Http\Requests\GetSettingsRequest;
test('get settings request rules', function () {
$request = new GetSettingsRequest;
$request = new GetSettingsRequest();
$this->assertEquals([
$this->assertEquals(
[
'settings' => [
'required'
'required',
],
'settings.*' => [
'required',
'string'
]
'string',
],
],
$request->rules()
);
@ -20,7 +21,7 @@ test('get settings request rules', function () {
test('get settings request authorize', function () {
$request = new GetSettingsRequest;
$request = new GetSettingsRequest();
$this->assertTrue($request->authorize());
});

View File

@ -5,59 +5,60 @@ use Crater\Models\Invoice;
use Crater\Rules\UniqueNumber;
test('invoice request validation rules', function () {
$request = new InvoicesRequest;
$request = new InvoicesRequest();
$this->assertEquals([
$this->assertEquals(
[
'invoice_date' => [
'required'
'required',
],
'due_date' => [
'required'
'required',
],
'user_id' => [
'required'
'required',
],
'discount' => [
'required'
'required',
],
'discount_val' => [
'required'
'required',
],
'sub_total' => [
'required'
'required',
],
'total' => [
'required'
'required',
],
'tax' => [
'required'
'required',
],
'invoice_template_id' => [
'required'
'required',
],
'items' => [
'required',
'array'
'array',
],
'items.*' => [
'required',
'max:255'
'max:255',
],
'items.*.description' => [
'max:255'
'max:255',
],
'items.*.name' => [
'required'
'required',
],
'items.*.quantity' => [
'required'
'required',
],
'items.*.price' => [
'required'
'required',
],
'invoice_number' => [
'required',
new UniqueNumber(Invoice::class)
new UniqueNumber(Invoice::class),
],
],
$request->rules()
@ -65,7 +66,7 @@ test('invoice request validation rules', function () {
});
test('invoices request authorize', function () {
$request = new InvoicesRequest;
$request = new InvoicesRequest();
$this->assertTrue($request->authorize());
});

View File

@ -3,28 +3,29 @@
use Crater\Http\Requests\ItemsRequest;
test('items request validation rules', function () {
$request = new ItemsRequest;
$request = new ItemsRequest();
$this->assertEquals([
$this->assertEquals(
[
'name' => [
'required'
'required',
],
'price' => [
'required'
'required',
],
'unit_id' => [
'nullable'
'nullable',
],
'description' => [
'nullable'
]
'nullable',
],
],
$request->rules()
);
});
test('item request authorize', function () {
$request = new ItemsRequest;
$request = new ItemsRequest();
$this->assertTrue($request->authorize());
});

View File

@ -3,20 +3,21 @@
use Crater\Http\Requests\PaymentMethodRequest;
test('payment method request validation rules', function () {
$request = new PaymentMethodRequest;
$request = new PaymentMethodRequest();
$this->assertEquals([
$this->assertEquals(
[
'name' => [
'required',
'unique:payment_methods,name'
]
'unique:payment_methods,name',
],
],
$request->rules()
);
});
test('payment method request authorize', function () {
$request = new PaymentMethodRequest;
$request = new PaymentMethodRequest();
$this->assertTrue($request->authorize());
});

View File

@ -5,21 +5,22 @@ use Crater\Models\Payment;
use Crater\Rules\UniqueNumber;
test('payment request validation rules', function () {
$request = new PaymentRequest;
$request = new PaymentRequest();
$this->assertEquals([
$this->assertEquals(
[
'payment_date' => [
'required'
'required',
],
'user_id' => [
'required'
'required',
],
'amount' => [
'required'
'required',
],
'payment_number' => [
'required',
new UniqueNumber(Payment::class)
new UniqueNumber(Payment::class),
],
'invoice_id' => [
'nullable',
@ -36,7 +37,7 @@ test('payment request validation rules', function () {
});
test('payment request authorize', function () {
$request = new PaymentRequest;
$request = new PaymentRequest();
$this->assertTrue($request->authorize());
});

View File

@ -3,24 +3,25 @@
use Crater\Http\Requests\TaxTypeRequest;
test('tax type request validation rules', function () {
$request = new TaxTypeRequest;
$request = new TaxTypeRequest();
$this->assertEquals([
$this->assertEquals(
[
'name' => [
'required'
'required',
],
'percent' => [
'required'
'required',
],
'description' => [
'nullable'
'nullable',
],
'compound_tax' => [
'nullable'
'nullable',
],
'collective_tax' => [
'nullable'
]
'nullable',
],
],
$request->rules()
);
@ -28,7 +29,7 @@ test('tax type request validation rules', function () {
test('tax type request authorize', function () {
$request = new TaxTypeRequest;
$request = new TaxTypeRequest();
$this->assertTrue($request->authorize());
});

View File

@ -3,20 +3,21 @@
use Crater\Http\Requests\UnitRequest;
test('unit request validation rules', function () {
$request = new UnitRequest;
$request = new UnitRequest();
$this->assertEquals([
$this->assertEquals(
[
'name' => [
'required',
'unique:units,name'
]
'unique:units,name',
],
],
$request->rules()
);
});
test('unit request authorize', function () {
$request = new UnitRequest;
$request = new UnitRequest();
$this->assertTrue($request->authorize());
});

View File

@ -3,15 +3,16 @@
use Crater\Http\Requests\UpdateSettingsRequest;
test('update settings request rules', function () {
$request = new UpdateSettingsRequest;
$request = new UpdateSettingsRequest();
$this->assertEquals([
$this->assertEquals(
[
'settings' => [
'required'
'required',
],
'settings.*' => [
'required'
]
'required',
],
],
$request->rules()
);
@ -19,7 +20,7 @@ test('update settings request rules', function () {
test('update settings request authorize', function () {
$request = new UpdateSettingsRequest;
$request = new UpdateSettingsRequest();
$this->assertTrue($request->authorize());
});