From 61a7aea0cd71577e267f676a042fb70c43e51f35 Mon Sep 17 00:00:00 2001 From: Mohit Panjwani Date: Sat, 16 Nov 2019 12:41:46 +0530 Subject: [PATCH 1/4] fix version compare check on listner.php --- app/Listeners/Updates/Listener.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/Listeners/Updates/Listener.php b/app/Listeners/Updates/Listener.php index 0d149c4f..4e44d98c 100644 --- a/app/Listeners/Updates/Listener.php +++ b/app/Listeners/Updates/Listener.php @@ -15,10 +15,10 @@ class Listener protected function check($event) { // Do not apply to the same or newer versions - if (version_compare($event->old, static::VERSION, '>=')) { - return false; + if (version_compare(static::VERSION, $event->old, '>')) { + return true; } - return true; + return false; } } From 2a0c6932ca08705cd4a33b9005d31ff9eddade99 Mon Sep 17 00:00:00 2001 From: Mohit Panjwani Date: Sat, 16 Nov 2019 13:27:37 +0530 Subject: [PATCH 2/4] fix update-app screen spacing and alerts --- app/Space/Updater.php | 6 +-- resources/assets/js/plugins/en.js | 6 ++- .../assets/js/views/settings/UpdateApp.vue | 49 +++++++++++++------ .../assets/plugins/vue-font-awesome/index.js | 6 ++- 4 files changed, 45 insertions(+), 22 deletions(-) diff --git a/app/Space/Updater.php b/app/Space/Updater.php index 83f8add3..f2de65c8 100644 --- a/app/Space/Updater.php +++ b/app/Space/Updater.php @@ -26,7 +26,7 @@ class Updater if ($response instanceof RequestException) { return [ 'success' => false, - 'errors' => 'Download Exception', + 'error' => 'Download Exception', 'data' => [ 'path' => $path ] @@ -84,13 +84,13 @@ class Updater return [ 'success' => true, - 'errors' => false, + 'error' => false, 'data' => [] ]; } catch (\Exception $e) { return [ 'success' => false, - 'errors' => 'Update error', + 'error' => 'Update error', 'data' => [] ]; } diff --git a/resources/assets/js/plugins/en.js b/resources/assets/js/plugins/en.js index dcbf2166..7eb954e8 100644 --- a/resources/assets/js/plugins/en.js +++ b/resources/assets/js/plugins/en.js @@ -672,9 +672,11 @@ export default { check_update: 'Check for updates', avail_update: 'New Update available', next_version: 'Next version', - update: 'Update', + update: 'Update Now', update_progress: 'Update in progress...', - progress_text: 'It will just take a few minutes. Please do not refresh the screen or close the window before the update finishes' + progress_text: 'It will just take a few minutes. Please do not refresh the screen or close the window before the update finishes', + update_success: 'App has been updated successfully', + latest_message: 'No update available! You are on the latest version.' } }, wizard: { diff --git a/resources/assets/js/views/settings/UpdateApp.vue b/resources/assets/js/views/settings/UpdateApp.vue index 0ea5349c..7bb07b3d 100644 --- a/resources/assets/js/views/settings/UpdateApp.vue +++ b/resources/assets/js/views/settings/UpdateApp.vue @@ -7,24 +7,24 @@ {{ $t('settings.update_app.description') }}


- - + + {{ $t('settings.update_app.check_update') }}
-

{{ $t('settings.update_app.avail_update') }}

+

{{ $t('settings.update_app.avail_update') }}


{{ description }}

- + {{ $t('settings.update_app.update') }}
-
+

{{ $t('settings.update_app.update_progress') }}

{{ $t('settings.update_app.progress_text') }} @@ -35,8 +35,8 @@

+