From b6af10b68ac13b2780ae501556dea5bdf4a16949 Mon Sep 17 00:00:00 2001 From: jayvirsinh_gohil Date: Sat, 16 Nov 2019 18:18:32 +0530 Subject: [PATCH] refactor items tax add and update --- app/Http/Controllers/ItemsController.php | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/app/Http/Controllers/ItemsController.php b/app/Http/Controllers/ItemsController.php index b9cbb4be..d8d138aa 100644 --- a/app/Http/Controllers/ItemsController.php +++ b/app/Http/Controllers/ItemsController.php @@ -55,6 +55,7 @@ class ItemsController extends Controller if ($request->has('taxes')) { foreach ($request->taxes as $tax) { + $tax['company_id'] = $request->header('company'); $item->taxes()->create($tax); } } @@ -75,12 +76,16 @@ class ItemsController extends Controller $item->price = $request->price; $item->save(); + $oldTaxes = $item->taxes->toArray(); + + foreach ($oldTaxes as $oldTax) { + Tax::destroy($oldTax['id']); + } + if ($request->has('taxes')) { foreach ($request->taxes as $tax) { - $item->taxes()->updateOrCreate( - ['tax_type_id' => $tax['tax_type_id']], - ['amount' => $tax['amount'], 'percent' => $tax['percent'], 'name' => $tax['name']] - ); + $tax['company_id'] = $request->header('company'); + $item->taxes()->create($tax); } }