TheCloneArmy/mcrcon
1
0
Fork 0
mirror of https://github.com/Tiiffi/mcrcon.git synced 2025-10-28 11:51:08 -04:00
Code Issues Packages Projects Releases Wiki Activity

Compare commits

base: TheCloneArmy:bc5617407d5110d1b303e1083a88e87fa5d4f082
Branches Tags
TheCloneArmy:master TheCloneArmy:Develop
TheCloneArmy:v0.7.3-develop TheCloneArmy:v0.7.2 TheCloneArmy:v0.7.1 TheCloneArmy:v0.6.2-develop TheCloneArmy:v0.6.1 TheCloneArmy:v0.0.5
..
compare: TheCloneArmy:v0.7.3-develop
Branches Tags
TheCloneArmy:Develop TheCloneArmy:master
TheCloneArmy:v0.7.3-develop TheCloneArmy:v0.7.2 TheCloneArmy:v0.7.1 TheCloneArmy:v0.6.2-develop TheCloneArmy:v0.6.1 TheCloneArmy:v0.0.5

2 Commits
bc5617407d ... v0.7.3-dev

Author SHA1 Message Date
Tiiffi
5d1c87b26f Don't call memcpy() if there is nothing to copy 2024-12-04 08:17:56 +02:00
Tiiffi
fd77ad7fc0 packet_build(): add [static 1] to generate warning if NULL pointer is passed 2024-12-03 05:40:45 +02:00
1 changed files with 3 additions and 3 deletions
Expand all files Collapse all files

6
mcrcon.c
View File

@ -90,7 +90,7 @@ int run_terminal_mode(int sock);
int run_commands(int argc, char *argv[]); int run_commands(int argc, char *argv[]);
// Rcon protocol related functions // Rcon protocol related functions
rc_packet* packet_build(int id, int cmd, char *s1); rc_packet* packet_build(int id, int cmd, char s[static 1]);
void packet_print(rc_packet *packet); void packet_print(rc_packet *packet);
bool rcon_auth(int sock, char *passwd); bool rcon_auth(int sock, char *passwd);
int rcon_command(int sock, char *command); int rcon_command(int sock, char *command);
@ -529,7 +529,7 @@ void packet_print(rc_packet *packet)
} }
} }
rc_packet *packet_build(int id, int cmd, char *s) rc_packet *packet_build(int id, int cmd, char s[static 1])
{ {
static rc_packet packet = {0}; static rc_packet packet = {0};
@ -547,7 +547,7 @@ rc_packet *packet_build(int id, int cmd, char *s)
packet.size = sizeof packet.id + sizeof packet.cmd + len + 2; packet.size = sizeof packet.id + sizeof packet.cmd + len + 2;
packet.id = id; packet.id = id;
packet.cmd = cmd; packet.cmd = cmd;
memcpy(packet.data, s, len); if (packet.size > 0) memcpy(packet.data, s, len);
packet.data[len] = 0; packet.data[len] = 0;
packet.data[len + 1] = 0; packet.data[len + 1] = 0;