Exit with appropriate return code if password is not provided, fixes #87

- Remove "ginstall" as "install" replacement on macOS
- Remove "-D" flag from "install" parameters

.travis.yml

@@ -1,20 +0,0 @@
-language: c
-sudo: false
-dist: trusty
-cache:
-  ccache: true
-compiler:
-- gcc
-- clang
-env:
-  global:
-  - EXTRAFLAGS='-v'
-  - PREFIX="${HOME}"
-install:
-- 'true'
-script:
-- make
-- ./mcrcon -h
-- ./mcrcon -v
-- make install
-- make uninstall

CHANGELOG.md

@@ -1,5 +1,26 @@
 #### Version history:
 
+###### 0.7.3
+ - Add support to Valve style rcon authentication
+ 
+###### 0.7.2
+ - Quit gracefully when Ctrl-D or Ctrl+C is pressed
+ - Remove "exit" and "quit" as quitting commands
+    * these are actual rcon commands on some servers
+ - Suppress compiler warning (strncpy)
+ - fix erroneous string length in packet building function
+ - Fix typo in ANSI escape sequence for LCYAN
+ - Make stdout and stderr unbuffered
+
+###### 0.7.1
+ - Deprecate `-i` flag for invoking terminal mode
+ - Add workaround to prevent server-side bug.
+   * https://bugs.mojang.com/browse/MC-154617
+
+###### 0.7.0
+ - Add -w option for rcon command throttling
+    * Thanks HorlogeSkynet @ Github
+
 ###### 0.6.2
  - Set default address to localhost
 

INSTALL.md

@@ -1,15 +1,15 @@
-Compiling and installing
+Building and installing
-------------------------
+-----------------------
 
 Only dependency is C library and POSIX getopt support. 
 
 Compiling with GCC or CLANG:
 
-    cc -std=gnu99 -Wpedantic -Wall -Wextra -Os -s -o mcrcon mcrcon.c
+    cc -std=gnu99 -Wpedantic -Wall -Wextra -O2 -o mcrcon mcrcon.c
     
-Note: on Window remember to link with winsockets by adding "-lws2_32" to your compiler command line.
+Note: on Windows remember to link with winsock by adding `-lws2_32` to your compiler command line.
 
-Or you can just run "make":
+Or you can just run "**make**":
 
     make           - compiles mcrcon
     make install   - installs compiled binaries and manpage to the system
@@ -19,4 +19,4 @@ Or you can just run "make":
         /usr/local/bin/mcrcon
         /usr/local/share/man/man1/mcrcon.1
 
-Makefile "install" and "uninstall" rules are disabled on windows.
+Makefile "**install**" and "**uninstall**" rules are disabled on windows.

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012-2019, Tiiffi <tiiffi at gmail>
+Copyright (c) 2012-2021, Tiiffi <tiiffi at gmail>
 
 This software is provided 'as-is', without any express or implied
 warranty. In no event will the authors be held liable for any damages
@@ -18,4 +18,3 @@ freely, subject to the following restrictions:
 
   3. This notice may not be removed or altered from any source
   distribution.
-  

Makefile

@@ -1,7 +1,10 @@
-# if you want to cross compile
+# if you want to cross compile:
-# export PATH=$PATH:/path/to/compiler/bin
+#   export PATH=$PATH:/path/to/compiler/bin
-# export CROSS_COMPILE=arm-none-linux-gnueabi-
+#   export CROSS_COMPILE=arm-none-linux-gnueabi-
-# make
+#   make
+#
+# Windows cross compile:
+#   x86_64-w64-mingw32-gcc -std=gnu99 -Wall -Wextra -Wpedantic -O2 -fstack-protector-all -o mcrcon.exe mcrcon.c -lws2_32
 
 EXENAME = mcrcon
 PREFIX ?= /usr/local
@@ -10,9 +13,9 @@ INSTALL = install
 LINKER =
 RM = rm -v -f
 
-CC = cc
+CC = gcc
-CFLAGS = -std=gnu99 -Wall -Wextra -Wpedantic -Os -s
+CFLAGS = -std=gnu99 -Wall -Wextra -Wpedantic -O2
-EXTRAFLAGS ?= -fstack-protector-strong
+EXTRAFLAGS ?= -fstack-protector-all
 
 ifeq ($(OS), Windows_NT)
 	LINKER = -lws2_32
@@ -20,11 +23,6 @@ ifeq ($(OS), Windows_NT)
 	RM = cmd /C del /F
 endif
 
-ifeq ($(shell uname), Darwin)
-	INSTALL = ginstall
-	CFLAGS = -std=gnu99 -Wall -Wextra -Wpedantic -Os
-endif
-
 .PHONY: all
 all: $(EXENAME)
 
@@ -34,8 +32,8 @@ $(EXENAME): mcrcon.c
 ifneq ($(OS), Windows_NT)
 .PHONY: install
 install:
-	$(INSTALL) -vD $(EXENAME) $(DESTDIR)$(PREFIX)/bin/$(EXENAME)
+	$(INSTALL) -v $(EXENAME) $(DESTDIR)$(PREFIX)/bin/$(EXENAME)
-	$(INSTALL) -vD -m 0644 mcrcon.1 $(DESTDIR)$(PREFIX)/share/man/man1/mcrcon.1
+	$(INSTALL) -v -m 0644 mcrcon.1 $(DESTDIR)$(PREFIX)/share/man/man1/mcrcon.1
 	@echo "\nmcrcon installed. Run 'make uninstall' if you want to uninstall.\n"
 
 .PHONY: uninstall

README.md

@@ -6,24 +6,30 @@ mcrcon is console based Minecraft [rcon](https://developer.valvesoftware.com/wik
 
 ### Installing:
 
-##### via packet manager:
+##### via package manager:
-See https://pkgs.org/download/mcrcon for available packages in various Linux distros.
+See https://pkgs.org/download/mcrcon and https://repology.org/project/mcrcon/packages for available packages in various Linux distros (note that some packages might be outdated).
 
-- Gentoo Linux: https://packages.gentoo.org/packages/games-util/mcrcon
+- Fedora: https://packages.fedoraproject.org/pkgs/mcrcon/mcrcon/
-- Arch Linux: https://aur.archlinux.org/packages/mcrcon/
+- Gentoo: https://packages.gentoo.org/packages/games-util/mcrcon
+- Arch: https://aur.archlinux.org/packages/mcrcon/
+- NixOS: https://search.nixos.org/packages?show=mcrcon
+- Snapcraft: https://snapcraft.io/mcrcon-nsg
+- Scoop: https://scoop.sh/#/apps?q=mcrcon
 
-##### from sources:
+##### building from sources:
 ```sh
 git clone https://github.com/Tiiffi/mcrcon.git
 cd mcrcon
 make
+
+# install is optional
 sudo make install
 ```
 Check [INSTALL.md](INSTALL.md) for more details.
 
-You can also download precompiled binaries*: https://github.com/Tiiffi/mcrcon/releases/latest
+Precompiled binaries*: https://github.com/Tiiffi/mcrcon/releases/latest
 
-<sub>*At the moment binaries are provided for Linux and Windows.</sub>
+<sub>*Binaries are provided for Linux and Windows.</sub>
 
 ---
 
@@ -41,9 +47,9 @@ Option:
   -s            Silent mode
   -c            Disable colors
   -r            Output raw packets
+  -w            Wait for specified duration (seconds) between each command (1 - 600s)
   -h            Print usage
   -v            Version information
-  -w            Wait for specified duration (seconds) between each command
 ```
 Server address, port and password can be set using following environment variables:
 ```
@@ -57,7 +63,9 @@ MCRCON_PASS
 - Rcon commands with spaces must be enclosed in quotes
 
 Example:
-  ```mcrcon -H my.minecraft.server -p password "say Server is restarting!" save-all stop```
+> Send three commands ("say", "save-all", "stop") and wait five seconds between the commands.
+
+  ```mcrcon -H my.minecraft.server -p password -w 5 "say Server is restarting!" save-all stop```
 
 ---
 
@@ -74,8 +82,7 @@ rcon.password=your_rcon_pasword
 ##### Contact:
 
 * WWW:            https://github.com/Tiiffi/mcrcon/
-* MAIL:           tiiffi at gmail
+* MAIL:           tiiffi+mcrcon at gmail
-* IRC:            tiiffi @ quakenet
 * BUG REPORTS:    https://github.com/Tiiffi/mcrcon/issues/
 
 ---
@@ -85,6 +92,3 @@ rcon.password=your_rcon_pasword
 This project is licensed under the zlib License - see the [LICENSE](LICENSE) file for details.
 
 ---
-
-<sub>Master:</sub> ![Master build](https://api.travis-ci.org/Tiiffi/mcrcon.svg?branch=master)
-<sub>Develop:</sub> ![Develop build](https://api.travis-ci.org/Tiiffi/mcrcon.svg?branch=develop)

mcrcon.1

@@ -1,7 +1,7 @@
 .\" Process this file with
 .\" groff -man -Tascii mcrcon.1
 .\"
-.TH MCRCON 1 "October 2019" "Version 0.6.2"
+.TH MCRCON 1 "November 2024" "Version 0.7.3"
 .SH NAME 
 mcrcon \- send rcon commands to a Minecraft server
 .SH SYNOPSIS
@@ -27,17 +27,17 @@ Silent mode
 Disable colors
 .IP -r
 Output raw packets
+.IP -w
+Wait for specified duration (seconds) between each command (1 - 600s)
 .IP -h
 Print usage
 .IP -v
 Output version information
-.IP -w
-Wait for specified duration (seconds) between each command
 .PP
 Commands with spaces must be enclosed in quotes.
 .br
 mcrcon will start in terminal mode if no commands are given.
-.SH ENVIRONMENTAL VARIABLES
+.SH ENVIRONMENT VARIABLES
 Server address, port and password can be set with following environment variables:
 .PP
 \fBMCRCON_HOST
@@ -58,9 +58,9 @@ Send "weather clear" command to server using custom port 1337
 \fBmcrcon\fR -H my.minecraft.server -P 1337 -p password "weather clear"
 .RE
 .PP
-Send three commands to server ("say", "save-all" and "stop"), and wait 2 seconds between them
+Send three commands ("say", "save-all", "stop") and wait five seconds between the commands.
 .RS
-\fBmcrcon\fR -H my.minecraft.server -p password -w 2 "say Server is restarting!" save-all stop
+\fBmcrcon\fR -H my.minecraft.server -p password -w 5 "say Server is restarting!" save-all stop
 .RE
 .SH BUGS
-Bugs can be reported to \fBtiiffi+mcrcon at gmail\fR or \fBhttps://github.com/Tiiffi/mcrcon/issues/\fR
+Report bugs to \fBtiiffi+mcrcon at gmail\fR or \fBhttps://github.com/Tiiffi/mcrcon/issues/\fR

mcrcon.c

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012-2019, Tiiffi <tiiffi at gmail>
+ * Copyright (c) 2012-2021, Tiiffi <tiiffi at gmail>
  *
  * This software is provided 'as-is', without any express or implied
  * warranty. In no event will the authors be held liable for any damages
@@ -24,11 +24,12 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdint.h>
-#include <stdbool.h>
 #include <string.h>
+#include <strings.h>
 #include <signal.h>
 #include <errno.h>
 #include <unistd.h>
+#include <limits.h>
 
 #ifdef _WIN32
     // for name resolving on windows
@@ -46,7 +47,7 @@
     #include <netdb.h>
 #endif
 
-#define VERSION "0.6.2"
+#define VERSION "0.7.3"
 #define IN_NAME "mcrcon"
 #define VER_STR IN_NAME" "VERSION" (built: "__DATE__" "__TIME__")"
 
@@ -56,7 +57,6 @@
 #define RCON_AUTH_RESPONSE      2
 #define RCON_PID                0xBADC0DE
 
-// a bit too big perhaps?
 #define DATA_BUFFSIZE 4096
 
 // rcon packet structure
@@ -65,42 +65,39 @@ typedef struct _rc_packet {
     int id;
     int cmd;
     char data[DATA_BUFFSIZE];
-    // ignoring string2 atm.
+    // ignoring string2 for now
 } rc_packet;
 
+
 // ===================================
 //  FUNCTION DEFINITIONS              
 // ===================================
 
-// endianness related functions
-bool        is_bigendian(void);
-int32_t     reverse_int32(int32_t n);
-
 // Network related functions
 #ifdef _WIN32
-void		net_init_WSA(void);
+void        net_init_WSA(void);
 #endif
-void		net_close(int sd);
+void        net_close(int sd);
-int			net_connect(const char *host, const char *port);
+int         net_connect(const char *host, const char *port);
-int			net_send(int sd, const uint8_t *buffer, size_t size);
+int         net_send(int sd, const uint8_t *buffer, size_t size);
-int			net_send_packet(int sd, rc_packet *packet);
+int         net_send_packet(int sd, rc_packet *packet);
-rc_packet*	net_recv_packet(int sd);
+rc_packet*  net_recv_packet(int sd);
-int			net_clean_incoming(int sd, int size);
+int         net_clean_incoming(int sd, int size);
 
 // Misc stuff
-void	    usage(void);
+void        usage(void);
 #ifndef _WIN32
-void	    print_color(int color);
+void        print_color(int color);
 #endif
-int		    get_line(char *buffer, int len);
+int         get_line(char *buffer, int len);
-int		    run_terminal_mode(int sock);
+int         run_terminal_mode(int sock);
-int		    run_commands(int argc, char *argv[]);
+int         run_commands(int argc, char *argv[]);
 
 // Rcon protocol related functions
-rc_packet*	packet_build(int id, int cmd, char *s1);
+rc_packet*  packet_build(int id, int cmd, char *s1);
-void		packet_print(rc_packet *packet);
+void        packet_print(rc_packet *packet);
-int	        rcon_auth(int sock, char *passwd);
+int         rcon_auth(int sock, char *passwd);
-int	        rcon_command(int sock, char *command);
+int         rcon_command(int sock, char *command);
 
 
 // =============================================
@@ -108,10 +105,10 @@ int	        rcon_command(int sock, char *command);
 // =============================================
 static int global_raw_output = 0;
 static int global_silent_mode = 0;
-static int global_print_colors = 1;
+static int global_disable_colors = 0;
 static int global_connection_alive = 1;
-static int global_wait_seconds = 0;
 static int global_rsock;
+static int global_wait_seconds = 0;
 
 #ifdef _WIN32
   // console coloring on windows
@@ -126,85 +123,98 @@ void exit_proc(void)
 }
 
 // Check windows & linux behaviour !!!
-void sighandler(/*int sig*/)
+void sighandler(int sig)
 {
+	if (sig == SIGINT)
+		putchar('\n');
+
 	global_connection_alive = 0;
 	#ifndef _WIN32
 	    exit(EXIT_SUCCESS);
 	#endif
 }
 
+#define MAX_WAIT_TIME 600
+
+unsigned int mcrcon_parse_seconds(char *str)
+{
+	char *end;
+	long result = strtol(str, &end, 10);
+
+	if (errno != 0) {
+		fprintf(stderr, "-w invalid value.\nerror %d: %s\n", errno, strerror(errno));
+		exit(EXIT_FAILURE);
+	}
+
+	if (end == str) {
+		fprintf(stderr, "-w invalid value (not a number?)\n");
+		exit(EXIT_FAILURE);
+	}
+
+	if (result <= 0 || result > MAX_WAIT_TIME) {
+		fprintf(stderr, "-w value out of range.\nAcceptable value is 1 - %d (seconds).\n", MAX_WAIT_TIME);
+		exit(EXIT_FAILURE);
+	}
+
+	return (unsigned int) result;
+}
+
 int main(int argc, char *argv[])
 {
-	int opt;
 	int terminal_mode = 0;
 
 	char *host = getenv("MCRCON_HOST");
 	char *pass = getenv("MCRCON_PASS");
 	char *port = getenv("MCRCON_PORT");
 	
-	if (!port)
+	if (!port) port = "25575";
-		port = "25575";
+	if (!host) host = "localhost";
 
-	if (!host)
+	// disable output buffering (https://github.com/Tiiffi/mcrcon/pull/39)
-		host = "localhost";
+	setvbuf(stdout, NULL, _IONBF, 0);
+	setvbuf(stderr, NULL, _IONBF, 0);
 
-	if(argc < 1 && pass == NULL)
+	if(argc < 1 && pass == NULL) usage();
-		usage();
 
 	// default getopt error handler enabled
 	opterr = 1;
-
+	int opt;
-	while ((opt = getopt(argc, argv, "vrtcshw:H:p:P:i")) != -1)
+	while ((opt = getopt(argc, argv, "vrtcshw:H:p:P:")) != -1)
 	{
-		switch (opt)
+		switch (opt) {
-		{
+			case 'H': host = optarg;                break;
-			case 'H': host = optarg;			break;
+			case 'P': port = optarg;                break;
-			case 'P': port = optarg;			break;
+			case 'p': pass = optarg;                break;
-			case 'p': pass = optarg;			break;
+			case 'c': global_disable_colors = 1;    break;
-			case 'C':
+			case 's': global_silent_mode = 1;       break;
-			case 'c': global_print_colors = 0;	break;
+			case 'i': /* reserved for interp mode */break;
-			case 'S':
+			case 't': terminal_mode = 1;            break;
-			case 's': global_silent_mode = 1;	break;
+			case 'r': global_raw_output = 1;        break;
-			case 'T':
-			case 't':
-			case 'I':
-			case 'i': terminal_mode = 1;		break;
-			case 'r': global_raw_output = 1;	break;
-			case 'v':
-				puts(VER_STR"\nhttps://github.com/Tiiffi/mcrcon");
-				exit(EXIT_SUCCESS);
-			case 'W':
 			case 'w':
-				global_wait_seconds = strtol(optarg, NULL, 10);
+				global_wait_seconds = mcrcon_parse_seconds(optarg);
-				if (errno != 0)
+			break;
-				{
-					fprintf(stderr, "Error %d: %s\n", errno, strerror(errno));
-					exit(EXIT_FAILURE);
-				}
-				break;
-			case 'h':
-			case '?': usage();		break;
-			/*
-			  if(optopt == 'P' || optopt == 'H' || optopt == 'p')
-		    	  fprintf (stderr, "Option -%c requires an argument.\n\n", optopt);
-			  else fprintf (stderr, "Unknown option -%c\n\n", optopt);
-			*/
 
-			default: exit(EXIT_FAILURE);
+			case 'v':
+				puts(VER_STR" - https://github.com/Tiiffi/mcrcon");
+				puts("Bug reports:\n\ttiiffi+mcrcon at gmail\n\thttps://github.com/Tiiffi/mcrcon/issues/");
+				exit(EXIT_SUCCESS);
+
+			case 'h': usage(); break;
+			case '?':
+			default:
+				puts("Try 'mcrcon -h' or 'man mcrcon' for help.");
+				exit(EXIT_FAILURE);
 		}
 	}
 
-	if (pass == NULL)
+	if (pass == NULL) {
-	{
+		puts("You must give password (-p password).\nTry 'mcrcon -h' or 'man mcrcon' for help.");
-		fputs("You must give password (-p password). Try 'mcrcon -h' or 'man mcrcon' for help.\n\n", stdout);
+		exit(EXIT_FAILURE);
-		return 0;
 	}
 
 	if(optind == argc && terminal_mode == 0)
 		terminal_mode = 1;
 
-
 	// safety features to prevent "IO: Connection reset" bug on the server side
 	atexit(&exit_proc);
 	signal(SIGABRT, &sighandler);
@@ -212,9 +222,10 @@ int main(int argc, char *argv[])
 	signal(SIGINT, &sighandler);
 
 	#ifdef _WIN32
-	    net_init_WSA();
+		net_init_WSA();
-	    console_handle = GetStdHandle(STD_OUTPUT_HANDLE);
+		console_handle = GetStdHandle(STD_OUTPUT_HANDLE);
-	    if (console_handle == INVALID_HANDLE_VALUE) console_handle = NULL;
+		if (console_handle == INVALID_HANDLE_VALUE)
+			console_handle = NULL;
 	#endif
 
 	// open socket
@@ -223,28 +234,23 @@ int main(int argc, char *argv[])
 	int exit_code = EXIT_SUCCESS;
 
 	// auth & commands
-	if (rcon_auth(global_rsock, pass))
+	if (rcon_auth(global_rsock, pass)) {
-	{
 		if (terminal_mode)
 			run_terminal_mode(global_rsock);
 		else
 			exit_code = run_commands(argc, argv);
 	}
-	else // auth failed
+	else { // auth failed
-	{
 		fprintf(stdout, "Authentication failed!\n");
 		exit_code = EXIT_FAILURE;
 	}
 
-	net_close(global_rsock);
+	exit(exit_code);
-	global_rsock = -1;
-
-	return exit_code;
 }
 
 void usage(void)
 {
-	fputs(
+	puts(
 		"Usage: "IN_NAME" [OPTIONS] [COMMANDS]\n\n"
 		"Send rcon commands to Minecraft server.\n\n"
 		"Options:\n"
@@ -255,21 +261,21 @@ void usage(void)
 		"  -s\t\tSilent mode\n"
 		"  -c\t\tDisable colors\n"
 		"  -r\t\tOutput raw packets\n"
+		"  -w\t\tWait for specified duration (seconds) between each command (1 - 600s)\n"
 		"  -h\t\tPrint usage\n"
-		"  -v\t\tVersion information\n"
+		"  -v\t\tVersion information\n\n"
- 		"  -w\t\tWait for specified duration (seconds) between each command\n\n"
 		"Server address, port and password can be set with following environment variables:\n"
 		"  MCRCON_HOST\n"
 		"  MCRCON_PORT\n"
-		"  MCRCON_PASS\n\n"
+		"  MCRCON_PASS\n"
-		,stdout
 	);
 
-    puts("mcrcon will start in terminal mode if no commands are given.");
+	puts (
-	puts("Command-line options will override environment variables.");
+		"- mcrcon will start in terminal mode if no commands are given\n"
-	puts("Rcon commands with spaces must be enclosed in quotes.\n");
+		"- Command-line options will override environment variables\n"
-	puts("Example:\n\t"IN_NAME" -H my.minecraft.server -p password \"say Server is restarting!\" save-all stop\n");
+		"- Rcon commands with spaces must be enclosed in quotes\n"
-	puts(VER_STR"\nReport bugs to tiiffi+mcrcon at gmail or https://github.com/Tiiffi/mcrcon/issues/\n");
+	);
+	puts("Example:\n\t"IN_NAME" -H my.minecraft.server -p password -w 5 \"say Server is restarting!\" save-all stop\n");
 
 	#ifdef _WIN32
 	    puts("Press enter to exit.");
@@ -289,8 +295,7 @@ void net_init_WSA(void)
 	WORD version = MAKEWORD(2, 2);
 
 	int err = WSAStartup(version, &wsadata);
-	if (err != 0)
+	if (err != 0) {
-	{
 		fprintf(stderr, "WSAStartup failed. Error: %d.\n", err);
 		exit(EXIT_FAILURE);
 	}
@@ -300,12 +305,12 @@ void net_init_WSA(void)
 // socket close and cleanup
 void net_close(int sd)
 {
-#ifdef _WIN32
+	#ifdef _WIN32
-	closesocket(sd);
+		closesocket(sd);
-	WSACleanup();
+		WSACleanup();
-#else
+	#else
-	close(sd);
+		close(sd);
-#endif
+	#endif
 }
 
 // Opens and connects socket
@@ -328,27 +333,26 @@ int net_connect(const char *host, const char *port)
 	#endif
 
 	int ret = getaddrinfo(host, port, &hints, &server_info);
-	if (ret != 0)
+	if (ret != 0) {
-	{
 		fprintf(stderr, "Name resolution failed.\n");
 		#ifdef _WIN32
 			fprintf(stderr, "Error %d: %s", ret, gai_strerror(ret));
 		#else
 			fprintf(stderr, "Error %d: %s\n", ret, gai_strerror(ret));
 		#endif
+
 		exit(EXIT_FAILURE);
 	}
 
 	// Go through the hosts and try to connect
-	for (p = server_info; p != NULL; p = p->ai_next)
+	for (p = server_info; p != NULL; p = p->ai_next) {
-	{
 		sd = socket(p->ai_family, p->ai_socktype, p->ai_protocol);
+
 		if (sd == -1)
 			continue;
 
 		ret = connect(sd, p->ai_addr, p->ai_addrlen);
-		if (ret == -1)
+		if (ret == -1) {
-		{
 			net_close(sd);
 			continue;
 		}
@@ -356,19 +360,18 @@ int net_connect(const char *host, const char *port)
 		break;
 	}
 
-	if (p == NULL)
+	if (p == NULL) {
-	{
 		/* TODO (Tiiffi): Check why windows does not report errors */
 		fprintf(stderr, "Connection failed.\n");
 		#ifndef _WIN32
 			fprintf(stderr, "Error %d: %s\n", errno, strerror(errno));
 		#endif
+
 		freeaddrinfo(server_info);
 		exit(EXIT_FAILURE);
 	}
 
 	freeaddrinfo(server_info);
-
 	return sd;
 }
 
@@ -377,11 +380,11 @@ int net_send(int sd, const uint8_t *buff, size_t size)
 	size_t sent = 0;
 	size_t left = size;
 
-	while (sent < size)
+	while (sent < size) {
-	{
 		int result = send(sd, (const char *) buff + sent, left, 0);
 
-		if (result == -1) return -1;
+		if (result == -1)
+			return -1;
 
 		sent += result;
 		left -= sent;
@@ -399,10 +402,9 @@ int net_send_packet(int sd, rc_packet *packet)
 
 	bytesleft = len = packet->size + sizeof(int);
 
-	while(total < len)
+	while (total < len) {
-	{
 		ret = send(sd, (char *) packet + total, bytesleft, 0);
-		if(ret == -1) { break; }
+		if(ret == -1) break;
 		total += ret;
 		bytesleft -= ret;
 	}
@@ -419,22 +421,20 @@ rc_packet *net_recv_packet(int sd)
 
 	int ret = recv(sd, (char *) &psize, sizeof(int), 0);
 
-	if (ret == 0)
+	if (ret == 0) {
-	{
 		fprintf(stderr, "Connection lost.\n");
 		global_connection_alive = 0;
 		return NULL;
 	}
 
-	if (ret != sizeof(int))
+	if (ret != sizeof(int)) {
-	{
 		fprintf(stderr, "Error: recv() failed. Invalid packet size (%d).\n", ret);
 		global_connection_alive = 0;
 		return NULL;
 	}
 
-	if (psize < 10 || psize > DATA_BUFFSIZE)
+	// NOTE(Tiiffi): This should fail if size is out of spec!
-	{
+	if (psize < 10 || psize > DATA_BUFFSIZE) {
 		fprintf(stderr, "Warning: invalid packet size (%d). Must over 10 and less than %d.\n", psize, DATA_BUFFSIZE);
 
 		if(psize > DATA_BUFFSIZE  || psize < 0) psize = DATA_BUFFSIZE;
@@ -446,11 +446,9 @@ rc_packet *net_recv_packet(int sd)
 	packet.size = psize;
 
 	int received = 0;
-	while (received < psize)
+	while (received < psize) {
-	{
 		ret = recv(sd, (char *) &packet + sizeof(int) + received, psize - received, 0);
-		if (ret == 0) /* connection closed before completing receving */
+		if (ret == 0) { /* connection closed before completing receving */
-		{
 			fprintf(stderr, "Connection lost.\n");
 			global_connection_alive = 0;
 			return NULL;
@@ -465,11 +463,9 @@ rc_packet *net_recv_packet(int sd)
 int net_clean_incoming(int sd, int size)
 {
 	char tmp[size];
-
 	int ret = recv(sd, tmp, size, 0);
 
-	if(ret == 0)
+	if(ret == 0) {
-	{
 		fprintf(stderr, "Connection lost.\n");
 		global_connection_alive = 0;
 	}
@@ -481,8 +477,7 @@ void print_color(int color)
 {
 	// sh compatible color array
 	#ifndef _WIN32
-	char *colors[] =
+	char *colors[] = {
-	{
 		"\033[0;30m",   /* 00 BLACK     0x30 */
 		"\033[0;34m",   /* 01 BLUE      0x31 */
 		"\033[0;32m",   /* 02 GREEN     0x32 */
@@ -494,7 +489,7 @@ void print_color(int color)
 		"\033[0;1;30m", /* 08 DGREY     0x38 */
 		"\033[0;1;34m", /* 09 LBLUE     0x39 */
 		"\033[0;1;32m", /* 10 LGREEN    0x61 */
-		"\033[0:1;36m", /* 11 LCYAN     0x62 */
+		"\033[0;1;36m", /* 11 LCYAN     0x62 */
 		"\033[0;1;31m", /* 12 LRED      0x63 */
 		"\033[0;1;35m", /* 13 LPURPLE   0x64 */
 		"\033[0;1;33m", /* 14 YELLOW    0x65 */
@@ -502,22 +497,22 @@ void print_color(int color)
 		"\033[4m"       /* 16 UNDERLINE 0x6e */
 	};
 
-	if(color == 0 || color == 0x72) /* 0x72: 'r' */
+	/* 0x72: 'r' */
-	{
+	if (color == 0 || color == 0x72) fputs("\033[0m", stdout); /* CANCEL COLOR */
-		fputs("\033[0m", stdout); /* CANCEL COLOR */
-	}
 	else
 	#endif
 	{
-		if(color >= 0x61 && color <= 0x66) color -= 0x57;
+		if (color >= 0x61 && color <= 0x66) color -= 0x57;
-		else if(color >= 0x30 && color <= 0x39) color -= 0x30;
+		else if (color >= 0x30 && color <= 0x39)
-		else if(color == 0x6e) color=16; /* 0x6e: 'n' */
+			color -= 0x30;
+		else if (color == 0x6e)
+			color = 16; /* 0x6e: 'n' */
 		else return;
 
 		#ifndef _WIN32
-		  fputs(colors[color], stdout);
+			fputs(colors[color], stdout);
 		#else
-		  SetConsoleTextAttribute(console_handle, color);
+			SetConsoleTextAttribute(console_handle, color);
 		#endif
 	}
 }
@@ -525,9 +520,10 @@ void print_color(int color)
 // this hacky mess might use some optimizing
 void packet_print(rc_packet *packet)
 {
-	if (global_raw_output == 1)
+	if (global_raw_output == 1) {
-	{
+		for (int i = 0; packet->data[i] != 0; ++i)
-		for (int i = 0; packet->data[i] != 0; ++i) putchar(packet->data[i]);
+			putchar(packet->data[i]);
+
 		return;
 	}
 
@@ -535,21 +531,17 @@ void packet_print(rc_packet *packet)
 	int def_color = 0;
 
 	#ifdef _WIN32
-	CONSOLE_SCREEN_BUFFER_INFO console_info;
+		CONSOLE_SCREEN_BUFFER_INFO console_info;
-
+		if (GetConsoleScreenBufferInfo(console_handle, &console_info) != 0) {
-	if (GetConsoleScreenBufferInfo(console_handle, &console_info) != 0)
+			def_color = console_info.wAttributes + 0x30;
-		def_color = console_info.wAttributes + 0x30;
+		} else def_color = 0x37;
-	else
-		def_color = 0x37;
 	#endif
 
 	// colors enabled so try to handle the bukkit colors for terminal
-	if (global_print_colors == 1)
+	if (global_disable_colors == 0) {
-	{
+		for (i = 0; (unsigned char) packet->data[i] != 0; ++i) {
-		for (i = 0; (unsigned char) packet->data[i] != 0; ++i)
-		{
 			if (packet->data[i] == 0x0A) print_color(def_color);
-			else if((unsigned char) packet->data[i] == 0xc2 && (unsigned char) packet->data[i+1] == 0xa7){
+			else if((unsigned char) packet->data[i] == 0xc2 && (unsigned char) packet->data[i+1] == 0xa7) {
 				print_color(packet->data[i+=2]);
 				continue;
 			}
@@ -558,11 +550,9 @@ void packet_print(rc_packet *packet)
 		print_color(def_color); // cancel coloring
 	}
 	// strip colors
-	else
+	else {
-	{
+		for (i = 0; (unsigned char) packet->data[i] != 0; ++i) {
-		for (i = 0; (unsigned char) packet->data[i] != 0; ++i)
+			if ((unsigned char) packet->data[i] == 0xc2 && (unsigned char) packet->data[i+1] == 0xa7) {
-		{
-			if ((unsigned char) packet->data[i] == 0xc2 && (unsigned char) packet->data[i+1] == 0xa7){
 				i+=2;
 				continue;
 			}	
@@ -571,8 +561,7 @@ void packet_print(rc_packet *packet)
 	}
 
 	// print newline if string has no newline
-	if (packet->data[i-1] != 10 && packet->data[i-1] != 13)
+	if (packet->data[i-1] != 10 && packet->data[i-1] != 13) putchar('\n');
-		putchar('\n');
 }
 
 rc_packet *packet_build(int id, int cmd, char *s1)
@@ -580,17 +569,16 @@ rc_packet *packet_build(int id, int cmd, char *s1)
 	static rc_packet packet = {0, 0, 0, { 0x00 }};
 
 	// size + id + cmd + s1 + s2 NULL terminator
-	int s1_len = strlen(s1);
+	int len = strlen(s1);
-	if (s1_len > DATA_BUFFSIZE)
+	if (len >= DATA_BUFFSIZE) {
-	{
+		fprintf(stderr, "Warning: Command string too long (%d). Maximum allowed: %d.\n", len, DATA_BUFFSIZE - 1);
-		fprintf(stderr, "Warning: Command string too long (%d). Maximum allowed: %d.\n", s1_len, DATA_BUFFSIZE);
 		return NULL;
 	}
 
-	packet.size = sizeof(int) * 2 + s1_len + 2;
+	packet.size = sizeof(int) * 2 + len + 2;
 	packet.id = id;
 	packet.cmd = cmd;
-	strncpy(packet.data, s1, DATA_BUFFSIZE);
+	strncpy(packet.data, s1, DATA_BUFFSIZE - 1);
 
 	return &packet;
 }
@@ -607,10 +595,18 @@ int rcon_auth(int sock, char *passwd)
 	if (!ret)
 		return 0; // send failed
 
+receive:
 	packet = net_recv_packet(sock);
 	if (packet == NULL)
 		return 0;
 
+	/* Valve rcon sends empty "RCON_RESPONSEVALUE" packet before real auth response
+	 * so we have to check packet type and try again if necessary.
+	 */
+	if (packet->cmd != RCON_AUTH_RESPONSE) {
+		goto receive;
+	}
+
 	// return 1 if authentication OK
 	return packet->id == -1 ? 0 : 1;
 }
@@ -618,8 +614,7 @@ int rcon_auth(int sock, char *passwd)
 int rcon_command(int sock, char *command)
 {
 	rc_packet *packet = packet_build(RCON_PID, RCON_EXEC_COMMAND, command);
-	if (packet == NULL)
+	if (packet == NULL) {
-	{
 		global_connection_alive = 0;
 		return 0;
 	}
@@ -633,16 +628,9 @@ int rcon_command(int sock, char *command)
 	if (packet->id != RCON_PID)
 		return 0;
 
-	if (!global_silent_mode)
+	if (!global_silent_mode) {
-	{
+		if (packet->size > 10)
-	/*
+		packet_print(packet);
-	if(packet->size == 10) {
-	    printf("Unknown command \"%s\". Type \"help\" or \"?\" for help.\n", command);
-	}
-	else
-	*/
-	if (packet->size > 10)
-			packet_print(packet);
 	}
 
 	return 1;
@@ -652,16 +640,14 @@ int run_commands(int argc, char *argv[])
 {
 	int i = optind;
 
-	for (;;)
+	for (;;) {
-	{
 		if (!rcon_command(global_rsock, argv[i]))
 			return EXIT_FAILURE;
 
 		if (++i >= argc)
 			return EXIT_SUCCESS;
 
-		if (global_wait_seconds > 0)
+		if (global_wait_seconds > 0) {
-		{
 			#ifdef _WIN32
 				Sleep(global_wait_seconds * 1000);
 			#else
@@ -677,18 +663,32 @@ int run_terminal_mode(int sock)
 	int ret = 0;
 	char command[DATA_BUFFSIZE] = {0x00};
 
-	puts("Logged in. Type \"Q\" to quit!");
+	puts("Logged in.\nType 'Q' or press Ctrl-D / Ctrl-C to disconnect.");
+
+	while (global_connection_alive) {
+		putchar('>');
 
-	while (global_connection_alive)
-	{
 		int len = get_line(command, DATA_BUFFSIZE);
-		if(command[0] == 'Q' && command[1] == 0)
+		if (len < 1) continue; 
+	
+		if (strcasecmp(command, "Q") == 0)
 			break;
 
-		if(len > 0 && global_connection_alive)
+		if (len > 0 && global_connection_alive)
 			ret += rcon_command(sock, command);
 
-		command[0] = len = 0;
+		/* Special case for "stop" command to prevent server-side bug.
+		 * https://bugs.mojang.com/browse/MC-154617
+		 * 
+		 * NOTE: This is hacky workaround which should be handled better to
+		 *       ensure compatibility with other servers using source RCON.
+		 * NOTE: strcasecmp() is POSIX function.
+		 */
+		if (strcasecmp(command, "stop") == 0) {
+			break;
+		}
+
+		//command[0] = len = 0;
 	}
 
 	return ret;
@@ -697,44 +697,26 @@ int run_terminal_mode(int sock)
 // gets line from stdin and deals with rubbish left in the input buffer
 int get_line(char *buffer, int bsize)
 {
-	int ch, len;
-
-	fputs(">", stdout);
 	char *ret = fgets(buffer, bsize, stdin);
-    if (ret == NULL) exit(EXIT_FAILURE);
+	if (ret == NULL) {
-
+		if (ferror(stdin)) {
-	if (buffer[0] == 0) global_connection_alive = 0;
+			fprintf(stderr, "Error %d: %s\n", errno, strerror(errno));
+			exit(EXIT_FAILURE);
+		}
+		putchar('\n');
+		exit(EXIT_SUCCESS);
+	}
 
 	// remove unwanted characters from the buffer
 	buffer[strcspn(buffer, "\r\n")] = '\0';
 
-	len = strlen(buffer);
+	int len = strlen(buffer);
 
 	// clean input buffer if needed 
-	if (len == bsize - 1)
+	if (len == bsize - 1) {
+		int ch;
 		while ((ch = getchar()) != '\n' && ch != EOF);
+	}
 
 	return len;
 }
-
-// http://www.ibm.com/developerworks/aix/library/au-endianc/
-bool is_bigendian(void)
-{
-	const int32_t n = 1;
-	if (*(uint8_t *) &n == 0 ) return true;
-	return false;
-}
-
-int32_t reverse_int32(int32_t n)
-{
-	int32_t tmp;
-	uint8_t *t = (uint8_t *) &tmp;
-	uint8_t *p = (uint8_t *) &n;
-
-	t[0] = p[3];
-	t[1] = p[2];
-	t[2] = p[1];
-	t[3] = p[0];
-
-	return tmp;
-}