Set versions of dependant packages to 'compatible releases'

mypy.ini

@@ -0,0 +1,9 @@
+[mypy]
+check_untyped_defs = True
+disallow_any_generics = True
+disallow_untyped_defs = True
+disallow_any_unimported = True
+no_implicit_optional = True
+warn_return_any = True
+show_error_codes = True
+warn_unused_ignores = True

pyhon/__main__.py

@@ -6,16 +6,17 @@ import logging
 import sys
 from getpass import getpass
 from pathlib import Path
+from typing import Tuple, Dict, Any
 
 if __name__ == "__main__":
     sys.path.insert(0, str(Path(__file__).parent.parent))
 
-from pyhon import Hon, HonAPI, helper, diagnose
+from pyhon import Hon, HonAPI, diagnose, printer
 
 _LOGGER = logging.getLogger(__name__)
 
 
-def get_arguments():
+def get_arguments() -> Dict[str, Any]:
     """Get parsed arguments."""
     parser = argparse.ArgumentParser(description="pyhOn: Command Line Utility")
     parser.add_argument("-u", "--user", help="user for haier hOn account")
@@ -36,10 +37,13 @@ def get_arguments():
         "translate", help="language (de, en, fr...)", metavar="LANGUAGE"
     )
     translate.add_argument("--json", help="print as json", action="store_true")
+    parser.add_argument(
+        "-i", "--import", help="import pyhon data", nargs="?", default=Path().cwd()
+    )
     return vars(parser.parse_args())
 
 
-async def translate(language, json_output=False):
+async def translate(language: str, json_output: bool = False) -> None:
     async with HonAPI(anonymous=True) as hon:
         keys = await hon.translation_keys(language)
     if json_output:
@@ -52,10 +56,10 @@ async def translate(language, json_output=False):
             .replace("\\r", "")
         )
         keys = json.loads(clean_keys)
-        print(helper.pretty_print(keys))
+        print(printer.pretty_print(keys))
 
 
-def get_login_data(args):
+def get_login_data(args: Dict[str, str]) -> Tuple[str, str]:
     if not (user := args["user"]):
         user = input("User for hOn account: ")
     if not (password := args["password"]):
@@ -63,44 +67,46 @@ def get_login_data(args):
     return user, password
 
 
-async def main():
+async def main() -> None:
     args = get_arguments()
     if language := args.get("translate"):
-        await translate(language, json_output=args.get("json"))
+        await translate(language, json_output=args.get("json", ""))
         return
-    async with Hon(*get_login_data(args)) as hon:
+    async with Hon(
+        *get_login_data(args), test_data_path=Path(args.get("import", ""))
+    ) as hon:
         for device in hon.appliances:
             if args.get("export"):
                 anonymous = args.get("anonymous", False)
-                path = Path(args.get("directory"))
+                path = Path(args.get("directory", "."))
                 if not args.get("zip"):
                     for file in await diagnose.appliance_data(device, path, anonymous):
                         print(f"Created {file}")
                 else:
-                    file = await diagnose.zip_archive(device, path, anonymous)
-                    print(f"Created {file}")
+                    archive = await diagnose.zip_archive(device, path, anonymous)
+                    print(f"Created {archive}")
                 continue
             print("=" * 10, device.appliance_type, "-", device.nick_name, "=" * 10)
             if args.get("keys"):
                 data = device.data.copy()
                 attr = "get" if args.get("all") else "pop"
                 print(
-                    helper.key_print(
+                    printer.key_print(
                         data["attributes"].__getattribute__(attr)("parameters")
                     )
                 )
-                print(helper.key_print(data.__getattribute__(attr)("appliance")))
-                print(helper.key_print(data))
+                print(printer.key_print(data.__getattribute__(attr)("appliance")))
+                print(printer.key_print(data))
                 print(
-                    helper.pretty_print(
-                        helper.create_command(device.commands, concat=True)
+                    printer.pretty_print(
+                        printer.create_commands(device.commands, concat=True)
                     )
                 )
             else:
                 print(diagnose.yaml_export(device))
 
 
-def start():
+def start() -> None:
     try:
         asyncio.run(main())
     except KeyboardInterrupt:

pyhon/appliance.py

@@ -1,15 +1,19 @@
 import importlib
 import logging
+import re
 from datetime import datetime, timedelta
 from pathlib import Path
-from typing import Optional, Dict, Any, TYPE_CHECKING
+from typing import Optional, Dict, Any, TYPE_CHECKING, List
 
-from pyhon import diagnose
+from pyhon import diagnose, exceptions
+from pyhon.appliances.base import ApplianceBase
 from pyhon.attributes import HonAttribute
 from pyhon.command_loader import HonCommandLoader
 from pyhon.commands import HonCommand
 from pyhon.parameter.base import HonParameter
+from pyhon.parameter.enum import HonParameterEnum
 from pyhon.parameter.range import HonParameterRange
+from pyhon.typedefs import Parameter
 
 if TYPE_CHECKING:
     from pyhon import HonAPI
@@ -25,26 +29,26 @@ class HonAppliance:
     ) -> None:
         if attributes := info.get("attributes"):
             info["attributes"] = {v["parName"]: v["parValue"] for v in attributes}
-        self._info: Dict = info
+        self._info: Dict[str, Any] = info
         self._api: Optional[HonAPI] = api
-        self._appliance_model: Dict = {}
+        self._appliance_model: Dict[str, Any] = {}
 
         self._commands: Dict[str, HonCommand] = {}
-        self._statistics: Dict = {}
-        self._attributes: Dict = {}
+        self._statistics: Dict[str, Any] = {}
+        self._attributes: Dict[str, Any] = {}
         self._zone: int = zone
         self._additional_data: Dict[str, Any] = {}
-        self._last_update = None
+        self._last_update: Optional[datetime] = None
         self._default_setting = HonParameter("", {}, "")
 
         try:
-            self._extra = importlib.import_module(
+            self._extra: Optional[ApplianceBase] = importlib.import_module(
                 f"pyhon.appliances.{self.appliance_type.lower()}"
             ).Appliance(self)
         except ModuleNotFoundError:
             self._extra = None
 
-    def __getitem__(self, item):
+    def __getitem__(self, item: str) -> Any:
         if self._zone:
             item += f"Z{self._zone}"
         if "." in item:
@@ -61,16 +65,17 @@ class HonAppliance:
             return self.attributes["parameters"][item].value
         return self.info[item]
 
-    def get(self, item, default=None):
+    def get(self, item: str, default: Any = None) -> Any:
         try:
             return self[item]
         except (KeyError, IndexError):
             return default
 
     def _check_name_zone(self, name: str, frontend: bool = True) -> str:
-        middle = " Z" if frontend else "_z"
-        if (attribute := self._info.get(name, "")) and self._zone:
-            return f"{attribute}{middle}{self._zone}"
+        zone = " Z" if frontend else "_z"
+        attribute: str = self._info.get(name, "")
+        if attribute and self._zone:
+            return f"{attribute}{zone}{self._zone}"
         return attribute
 
     @property
@@ -87,7 +92,11 @@ class HonAppliance:
 
     @property
     def unique_id(self) -> str:
-        return self._check_name_zone("macAddress", frontend=False)
+        default_mac = "xx-xx-xx-xx-xx-xx"
+        import_name = f"{self.appliance_type.lower()}_{self.appliance_model_id}"
+        result = self._check_name_zone("macAddress", frontend=False)
+        result = result.replace(default_mac, import_name)
+        return result
 
     @property
     def model_name(self) -> str:
@@ -95,17 +104,22 @@ class HonAppliance:
 
     @property
     def brand(self) -> str:
-        return self._check_name_zone("brand")
+        brand = self._check_name_zone("brand")
+        return brand[0].upper() + brand[1:]
 
     @property
     def nick_name(self) -> str:
-        return self._check_name_zone("nickName")
+        result = self._check_name_zone("nickName")
+        if not result or re.findall("^[xX1\\s-]+$", result):
+            return self.model_name
+        return result
 
     @property
     def code(self) -> str:
-        if code := self.info.get("code"):
+        code: str = self.info.get("code", "")
+        if code:
             return code
-        serial_number = self.info.get("serialNumber", "")
+        serial_number: str = self.info.get("serialNumber", "")
         return serial_number[:8] if len(serial_number) < 18 else serial_number[:11]
 
     @property
@@ -113,7 +127,7 @@ class HonAppliance:
         return self._info.get("applianceModelId", 0)
 
     @property
-    def options(self):
+    def options(self) -> Dict[str, Any]:
         return self._appliance_model.get("options", {})
 
     @property
@@ -121,19 +135,19 @@ class HonAppliance:
         return self._commands
 
     @property
-    def attributes(self):
+    def attributes(self) -> Dict[str, Any]:
         return self._attributes
 
     @property
-    def statistics(self):
+    def statistics(self) -> Dict[str, Any]:
         return self._statistics
 
     @property
-    def info(self):
+    def info(self) -> Dict[str, Any]:
         return self._info
 
     @property
-    def additional_data(self):
+    def additional_data(self) -> Dict[str, Any]:
         return self._additional_data
 
     @property
@@ -141,33 +155,38 @@ class HonAppliance:
         return self._zone
 
     @property
-    def api(self) -> Optional["HonAPI"]:
+    def api(self) -> "HonAPI":
+        """api connection object"""
+        if self._api is None:
+            raise exceptions.NoAuthenticationException("Missing hOn login")
         return self._api
 
-    async def load_commands(self):
+    async def load_commands(self) -> None:
         command_loader = HonCommandLoader(self.api, self)
         await command_loader.load_commands()
         self._commands = command_loader.commands
         self._additional_data = command_loader.additional_data
         self._appliance_model = command_loader.appliance_data
+        self.sync_params_to_command("settings")
 
-    async def load_attributes(self):
-        self._attributes = await self.api.load_attributes(self)
-        for name, values in self._attributes.pop("shadow").get("parameters").items():
+    async def load_attributes(self) -> None:
+        attributes = await self.api.load_attributes(self)
+        for name, values in attributes.pop("shadow", {}).get("parameters", {}).items():
             if name in self._attributes.get("parameters", {}):
                 self._attributes["parameters"][name].update(values)
             else:
                 self._attributes.setdefault("parameters", {})[name] = HonAttribute(
                     values
                 )
+        self._attributes |= attributes
         if self._extra:
             self._attributes = self._extra.attributes(self._attributes)
 
-    async def load_statistics(self):
+    async def load_statistics(self) -> None:
         self._statistics = await self.api.load_statistics(self)
         self._statistics |= await self.api.load_maintenance(self)
 
-    async def update(self, force=False):
+    async def update(self, force: bool = False) -> None:
         now = datetime.now()
         if (
             force
@@ -177,14 +196,15 @@ class HonAppliance:
         ):
             self._last_update = now
             await self.load_attributes()
+            self.sync_params_to_command("settings")
 
     @property
-    def command_parameters(self):
+    def command_parameters(self) -> Dict[str, Dict[str, str | float]]:
         return {n: c.parameter_value for n, c in self._commands.items()}
 
     @property
-    def settings(self):
-        result = {}
+    def settings(self) -> Dict[str, Parameter]:
+        result: Dict[str, Parameter] = {}
         for name, command in self._commands.items():
             for key in command.setting_keys:
                 setting = command.settings.get(key, self._default_setting)
@@ -194,7 +214,7 @@ class HonAppliance:
         return result
 
     @property
-    def available_settings(self):
+    def available_settings(self) -> List[str]:
         result = []
         for name, command in self._commands.items():
             for key in command.setting_keys:
@@ -202,7 +222,7 @@ class HonAppliance:
         return result
 
     @property
-    def data(self):
+    def data(self) -> Dict[str, Any]:
         result = {
             "attributes": self.attributes,
             "appliance": self.info,
@@ -220,15 +240,34 @@ class HonAppliance:
     async def data_archive(self, path: Path) -> str:
         return await diagnose.zip_archive(self, path, anonymous=True)
 
-    def sync_to_params(self, command_name):
-        command: HonCommand = self.commands.get(command_name)
-        for key, value in self.attributes.get("parameters", {}).items():
-            if isinstance(value, str) and (new := command.parameters.get(key)):
+    def sync_command_to_params(self, command_name: str) -> None:
+        if not (command := self.commands.get(command_name)):
+            return
+        for key in self.attributes.get("parameters", {}):
+            if new := command.parameters.get(key):
                 self.attributes["parameters"][key].update(
                     str(new.intern_value), shield=True
                 )
 
-    def sync_command(self, main, target=None) -> None:
+    def sync_params_to_command(self, command_name: str) -> None:
+        if not (command := self.commands.get(command_name)):
+            return
+        for key in command.setting_keys:
+            if (
+                new := self.attributes.get("parameters", {}).get(key)
+            ) is None or new.value == "":
+                continue
+            setting = command.settings[key]
+            try:
+                if not isinstance(setting, HonParameterRange):
+                    command.settings[key].value = str(new.value)
+                else:
+                    command.settings[key].value = float(new.value)
+            except ValueError as error:
+                _LOGGER.info("Can't set %s - %s", key, error)
+                continue
+
+    def sync_command(self, main: str, target: Optional[List[str] | str] = None) -> None:
         base: Optional[HonCommand] = self.commands.get(main)
         if not base:
             return
@@ -247,4 +286,6 @@ class HonAppliance:
                         parameter.max = int(base_value.value)
                         parameter.min = int(base_value.value)
                         parameter.step = 1
+                    elif isinstance(parameter, HonParameterEnum):
+                        parameter.values = base_value.values
                     parameter.value = base_value.value

pyhon/appliances/base.py

@@ -1,15 +1,25 @@
+from typing import Dict, Any, TYPE_CHECKING
+
+from pyhon.parameter.program import HonParameterProgram
+
+if TYPE_CHECKING:
+    from pyhon.appliance import HonAppliance
+
+
 class ApplianceBase:
-    def __init__(self, appliance):
+    def __init__(self, appliance: "HonAppliance"):
         self.parent = appliance
 
-    def attributes(self, data):
+    def attributes(self, data: Dict[str, Any]) -> Dict[str, Any]:
         program_name = "No Program"
         if program := int(str(data.get("parameters", {}).get("prCode", "0"))):
             if start_cmd := self.parent.settings.get("startProgram.program"):
-                if ids := start_cmd.ids:
+                if isinstance(start_cmd, HonParameterProgram) and (
+                    ids := start_cmd.ids
+                ):
                     program_name = ids.get(program, program_name)
         data["programName"] = program_name
         return data
 
-    def settings(self, settings):
+    def settings(self, settings: Dict[str, Any]) -> Dict[str, Any]:
         return settings

pyhon/appliances/dw.py

@@ -1,8 +1,10 @@
+from typing import Any, Dict
+
 from pyhon.appliances.base import ApplianceBase
 
 
 class Appliance(ApplianceBase):
-    def attributes(self, data):
+    def attributes(self, data: Dict[str, Any]) -> Dict[str, Any]:
         data = super().attributes(data)
         if data.get("lastConnEvent", {}).get("category", "") == "DISCONNECTED":
             data["parameters"]["machMode"].value = "0"

pyhon/appliances/ov.py

@@ -1,8 +1,11 @@
+from typing import Any, Dict
+
 from pyhon.appliances.base import ApplianceBase
+from pyhon.parameter.program import HonParameterProgram
 
 
 class Appliance(ApplianceBase):
-    def attributes(self, data):
+    def attributes(self, data: Dict[str, Any]) -> Dict[str, Any]:
         data = super().attributes(data)
         if data.get("lastConnEvent", {}).get("category", "") == "DISCONNECTED":
             data["parameters"]["temp"].value = "0"
@@ -11,9 +14,4 @@ class Appliance(ApplianceBase):
             data["parameters"]["remainingTimeMM"].value = "0"
 
         data["active"] = data["parameters"]["onOffStatus"] == "1"
-
-        if program := int(data["parameters"]["prCode"]):
-            ids = self.parent.settings["startProgram.program"].ids
-            data["programName"] = ids.get(program, "")
-
         return data

pyhon/appliances/ref.py

@@ -1,8 +1,10 @@
+from typing import Dict, Any
+
 from pyhon.appliances.base import ApplianceBase
 
 
 class Appliance(ApplianceBase):
-    def attributes(self, data):
+    def attributes(self, data: Dict[str, Any]) -> Dict[str, Any]:
         data = super().attributes(data)
         if data["parameters"]["holidayMode"] == "1":
             data["modeZ1"] = "holiday"

pyhon/appliances/td.py

@@ -1,9 +1,11 @@
+from typing import Any, Dict
+
 from pyhon.appliances.base import ApplianceBase
 from pyhon.parameter.fixed import HonParameterFixed
 
 
 class Appliance(ApplianceBase):
-    def attributes(self, data):
+    def attributes(self, data: Dict[str, Any]) -> Dict[str, Any]:
         data = super().attributes(data)
         if data.get("lastConnEvent", {}).get("category", "") == "DISCONNECTED":
             data["parameters"]["machMode"].value = "0"
@@ -11,7 +13,7 @@ class Appliance(ApplianceBase):
         data["pause"] = data["parameters"]["machMode"] == "3"
         return data
 
-    def settings(self, settings):
+    def settings(self, settings: Dict[str, Any]) -> Dict[str, Any]:
         dry_level = settings.get("startProgram.dryLevel")
         if isinstance(dry_level, HonParameterFixed) and dry_level.value == "11":
             settings.pop("startProgram.dryLevel", None)

pyhon/appliances/wd.py

@@ -1,8 +1,10 @@
+from typing import Dict, Any
+
 from pyhon.appliances.base import ApplianceBase
 
 
 class Appliance(ApplianceBase):
-    def attributes(self, data):
+    def attributes(self, data: Dict[str, Any]) -> Dict[str, Any]:
         data = super().attributes(data)
         if data.get("lastConnEvent", {}).get("category", "") == "DISCONNECTED":
             data["parameters"]["machMode"].value = "0"
@@ -10,5 +12,5 @@ class Appliance(ApplianceBase):
         data["pause"] = data["parameters"]["machMode"] == "3"
         return data
 
-    def settings(self, settings):
+    def settings(self, settings: Dict[str, Any]) -> Dict[str, Any]:
         return settings

pyhon/appliances/wm.py

@@ -1,8 +1,10 @@
+from typing import Any, Dict
+
 from pyhon.appliances.base import ApplianceBase
 
 
 class Appliance(ApplianceBase):
-    def attributes(self, data):
+    def attributes(self, data: Dict[str, Any]) -> Dict[str, Any]:
         data = super().attributes(data)
         if data.get("lastConnEvent", {}).get("category", "") == "DISCONNECTED":
             data["parameters"]["machMode"].value = "0"
@@ -10,5 +12,5 @@ class Appliance(ApplianceBase):
         data["pause"] = data["parameters"]["machMode"] == "3"
         return data
 
-    def settings(self, settings):
+    def settings(self, settings: Dict[str, Any]) -> Dict[str, Any]:
         return settings

pyhon/attributes.py

@@ -7,7 +7,7 @@ from pyhon.helper import str_to_float
 class HonAttribute:
     _LOCK_TIMEOUT: Final = 10
 
-    def __init__(self, data):
+    def __init__(self, data: Dict[str, str] | str):
         self._value: str = ""
         self._last_update: Optional[datetime] = None
         self._lock_timestamp: Optional[datetime] = None
@@ -22,7 +22,7 @@ class HonAttribute:
             return self._value
 
     @value.setter
-    def value(self, value) -> None:
+    def value(self, value: str) -> None:
         self._value = value
 
     @property

pyhon/command_loader.py

@@ -1,7 +1,7 @@
 import asyncio
 from contextlib import suppress
 from copy import copy
-from typing import Dict, Any, Optional, TYPE_CHECKING, List
+from typing import Dict, Any, Optional, TYPE_CHECKING, List, Collection
 
 from pyhon.commands import HonCommand
 from pyhon.parameter.fixed import HonParameterFixed
@@ -15,7 +15,7 @@ if TYPE_CHECKING:
 class HonCommandLoader:
     """Loads and parses hOn command data"""
 
-    def __init__(self, api, appliance):
+    def __init__(self, api: "HonAPI", appliance: "HonAppliance") -> None:
         self._api_commands: Dict[str, Any] = {}
         self._favourites: List[Dict[str, Any]] = []
         self._command_history: List[Dict[str, Any]] = []
@@ -52,25 +52,25 @@ class HonCommandLoader:
         """Get command additional data"""
         return self._additional_data
 
-    async def load_commands(self):
+    async def load_commands(self) -> None:
         """Trigger loading of command data"""
         await self._load_data()
-        self._appliance_data = self._api_commands.pop("applianceModel")
+        self._appliance_data = self._api_commands.pop("applianceModel", {})
         self._get_commands()
         self._add_favourites()
         self._recover_last_command_states()
 
-    async def _load_commands(self):
+    async def _load_commands(self) -> None:
         self._api_commands = await self._api.load_commands(self._appliance)
 
-    async def _load_favourites(self):
+    async def _load_favourites(self) -> None:
         self._favourites = await self._api.load_favourites(self._appliance)
 
-    async def _load_command_history(self):
+    async def _load_command_history(self) -> None:
         self._command_history = await self._api.load_command_history(self._appliance)
 
-    async def _load_data(self):
-        """Request parallel all relevant data"""
+    async def _load_data(self) -> None:
+        """Callback parallel all relevant data"""
         await asyncio.gather(
             *[
                 self._load_commands(),
@@ -102,14 +102,24 @@ class HonCommandLoader:
         self._commands = {c.name: c for c in commands}
 
     def _parse_command(
-        self, data: Dict[str, Any] | str, command_name: str, **kwargs
+        self,
+        data: Dict[str, Any] | str,
+        command_name: str,
+        categories: Optional[Dict[str, "HonCommand"]] = None,
+        category_name: str = "",
     ) -> Optional[HonCommand]:
         """Try to crate HonCommand object"""
         if not isinstance(data, dict):
             self._additional_data[command_name] = data
             return None
         if self._is_command(data):
-            return HonCommand(command_name, data, self._appliance, **kwargs)
+            return HonCommand(
+                command_name,
+                data,
+                self._appliance,
+                category_name=category_name,
+                categories=categories,
+            )
         if category := self._parse_categories(data, command_name):
             return category
         return None
@@ -120,8 +130,9 @@ class HonCommandLoader:
         """Parse categories and create reference to other"""
         categories: Dict[str, HonCommand] = {}
         for category, value in data.items():
-            kwargs = {"category_name": category, "categories": categories}
-            if command := self._parse_command(value, command_name, **kwargs):
+            if command := self._parse_command(
+                value, command_name, category_name=category, categories=categories
+            ):
                 categories[self._clean_name(category)] = command
         if categories:
             # setParameters should be at first place
@@ -176,18 +187,19 @@ class HonCommandLoader:
             command = favourite.get("command", {})
             command_name = command.get("commandName", "")
             program_name = self._clean_name(command.get("programName", ""))
-            base: HonCommand = copy(
-                self.commands[command_name].categories[program_name]
-            )
+            if not (base := self.commands[command_name].categories.get(program_name)):
+                continue
+            base_command: HonCommand = copy(base)
             for data in command.values():
                 if isinstance(data, str):
                     continue
                 for key, value in data.items():
-                    if parameter := base.parameters.get(key):
+                    if parameter := base_command.parameters.get(key):
                         with suppress(ValueError):
                             parameter.value = value
             extra_param = HonParameterFixed("favourite", {"fixedValue": "1"}, "custom")
-            base.parameters.update(favourite=extra_param)
-            if isinstance(program := base.parameters["program"], HonParameterProgram):
+            base_command.parameters.update(favourite=extra_param)
+            program = base_command.parameters["program"]
+            if isinstance(program, HonParameterProgram):
                 program.set_value(name)
-            self.commands[command_name].categories[name] = base
+            self.commands[command_name].categories[name] = base_command

pyhon/commands.py

@@ -9,6 +9,7 @@ from pyhon.parameter.fixed import HonParameterFixed
 from pyhon.parameter.program import HonParameterProgram
 from pyhon.parameter.range import HonParameterRange
 from pyhon.rules import HonRuleSet
+from pyhon.typedefs import Parameter
 
 if TYPE_CHECKING:
     from pyhon import HonAPI
@@ -43,7 +44,7 @@ class HonCommand:
         return f"{self._name} command"
 
     @property
-    def name(self):
+    def name(self) -> str:
         return self._name
 
     @property
@@ -57,7 +58,7 @@ class HonCommand:
         return self._appliance
 
     @property
-    def data(self):
+    def data(self) -> Dict[str, Any]:
         return self._data
 
     @property
@@ -79,14 +80,16 @@ class HonCommand:
     def parameter_value(self) -> Dict[str, Union[str, float]]:
         return {n: p.value for n, p in self._parameters.items()}
 
-    def _load_parameters(self, attributes):
+    def _load_parameters(self, attributes: Dict[str, Dict[str, Any]]) -> None:
         for key, items in attributes.items():
             for name, data in items.items():
                 self._create_parameters(data, name, key)
         for rule in self._rules:
             rule.patch()
 
-    def _create_parameters(self, data: Dict, name: str, parameter: str) -> None:
+    def _create_parameters(
+        self, data: Dict[str, Any], name: str, parameter: str
+    ) -> None:
         if name == "zoneMap" and self._appliance.zone:
             data["default"] = self._appliance.zone
         if data.get("category") == "rule":
@@ -112,7 +115,7 @@ class HonCommand:
         params = self.parameter_groups.get("parameters", {})
         ancillary_params = self.parameter_groups.get("ancillaryParameters", {})
         ancillary_params.pop("programRules", None)
-        self.appliance.sync_to_params(self.name)
+        self.appliance.sync_command_to_params(self.name)
         try:
             result = await self.api.send_command(
                 self._appliance, self._name, params, ancillary_params
@@ -147,7 +150,7 @@ class HonCommand:
         )
 
     @staticmethod
-    def _more_options(first: HonParameter, second: HonParameter):
+    def _more_options(first: Parameter, second: Parameter) -> Parameter:
         if isinstance(first, HonParameterFixed) and not isinstance(
             second, HonParameterFixed
         ):
@@ -157,8 +160,8 @@ class HonCommand:
         return first
 
     @property
-    def available_settings(self) -> Dict[str, HonParameter]:
-        result: Dict[str, HonParameter] = {}
+    def available_settings(self) -> Dict[str, Parameter]:
+        result: Dict[str, Parameter] = {}
         for command in self.categories.values():
             for name, parameter in command.parameters.items():
                 if name in result:

pyhon/connection/api.py

@@ -3,7 +3,8 @@ import logging
 from datetime import datetime
 from pathlib import Path
 from pprint import pformat
-from typing import Dict, Optional, Any, List, no_type_check
+from types import TracebackType
+from typing import Dict, Optional, Any, List, no_type_check, Type
 
 from aiohttp import ClientSession
 from typing_extensions import Self
@@ -36,7 +37,12 @@ class HonAPI:
     async def __aenter__(self) -> Self:
         return await self.create()
 
-    async def __aexit__(self, exc_type, exc_val, exc_tb) -> None:
+    async def __aexit__(
+        self,
+        exc_type: Optional[Type[BaseException]],
+        exc: Optional[BaseException],
+        traceback: Optional[TracebackType],
+    ) -> None:
         await self.close()
 
     @property
@@ -46,13 +52,13 @@ class HonAPI:
         return self._hon.auth
 
     @property
-    def _hon(self):
+    def _hon(self) -> HonConnectionHandler:
         if self._hon_handler is None:
             raise exceptions.NoAuthenticationException
         return self._hon_handler
 
     @property
-    def _hon_anonymous(self):
+    def _hon_anonymous(self) -> HonAnonymousConnectionHandler:
         if self._hon_anonymous_handler is None:
             raise exceptions.NoAuthenticationException
         return self._hon_anonymous_handler
@@ -69,12 +75,16 @@ class HonAPI:
 
     async def load_appliances(self) -> List[Dict[str, Any]]:
         async with self._hon.get(f"{const.API_URL}/commands/v1/appliance") as resp:
-            if result := await resp.json():
-                return result.get("payload", {}).get("appliances", {})
+            result = await resp.json()
+        if result:
+            appliances: List[Dict[str, Any]] = result.get("payload", {}).get(
+                "appliances", {}
+            )
+            return appliances
         return []
 
     async def load_commands(self, appliance: HonAppliance) -> Dict[str, Any]:
-        params: Dict = {
+        params: Dict[str, str | int] = {
             "applianceType": appliance.appliance_type,
             "applianceModelId": appliance.appliance_model_id,
             "macAddress": appliance.mac_address,
@@ -90,7 +100,7 @@ class HonAPI:
             params["series"] = series
         url: str = f"{const.API_URL}/commands/v1/retrieve"
         async with self._hon.get(url, params=params) as response:
-            result: Dict = (await response.json()).get("payload", {})
+            result: Dict[str, Any] = (await response.json()).get("payload", {})
             if not result or result.pop("resultCode") != "0":
                 _LOGGER.error(await response.json())
                 return {}
@@ -103,76 +113,86 @@ class HonAPI:
             f"{const.API_URL}/commands/v1/appliance/{appliance.mac_address}/history"
         )
         async with self._hon.get(url) as response:
-            result: Dict = await response.json()
-            if not result or not result.get("payload"):
-                return []
-            return result["payload"]["history"]
+            result: Dict[str, Any] = await response.json()
+        if not result or not result.get("payload"):
+            return []
+        command_history: List[Dict[str, Any]] = result["payload"]["history"]
+        return command_history
 
     async def load_favourites(self, appliance: HonAppliance) -> List[Dict[str, Any]]:
         url: str = (
             f"{const.API_URL}/commands/v1/appliance/{appliance.mac_address}/favourite"
         )
         async with self._hon.get(url) as response:
-            result: Dict = await response.json()
-            if not result or not result.get("payload"):
-                return []
-            return result["payload"]["favourites"]
+            result: Dict[str, Any] = await response.json()
+        if not result or not result.get("payload"):
+            return []
+        favourites: List[Dict[str, Any]] = result["payload"]["favourites"]
+        return favourites
 
     async def load_last_activity(self, appliance: HonAppliance) -> Dict[str, Any]:
         url: str = f"{const.API_URL}/commands/v1/retrieve-last-activity"
-        params: Dict = {"macAddress": appliance.mac_address}
+        params: Dict[str, str] = {"macAddress": appliance.mac_address}
         async with self._hon.get(url, params=params) as response:
-            result: Dict = await response.json()
-            if result and (activity := result.get("attributes")):
-                return activity
+            result: Dict[str, Any] = await response.json()
+            if result:
+                activity: Dict[str, Any] = result.get("attributes", "")
+                if activity:
+                    return activity
         return {}
 
     async def load_appliance_data(self, appliance: HonAppliance) -> Dict[str, Any]:
         url: str = f"{const.API_URL}/commands/v1/appliance-model"
-        params: Dict = {
+        params: Dict[str, str] = {
             "code": appliance.code,
             "macAddress": appliance.mac_address,
         }
         async with self._hon.get(url, params=params) as response:
-            result: Dict = await response.json()
+            result: Dict[str, Any] = await response.json()
             if result:
-                return result.get("payload", {}).get("applianceModel", {})
+                appliance_data: Dict[str, Any] = result.get("payload", {}).get(
+                    "applianceModel", {}
+                )
+                return appliance_data
         return {}
 
     async def load_attributes(self, appliance: HonAppliance) -> Dict[str, Any]:
-        params: Dict = {
+        params: Dict[str, str] = {
             "macAddress": appliance.mac_address,
             "applianceType": appliance.appliance_type,
             "category": "CYCLE",
         }
         url: str = f"{const.API_URL}/commands/v1/context"
         async with self._hon.get(url, params=params) as response:
-            return (await response.json()).get("payload", {})
+            attributes: Dict[str, Any] = (await response.json()).get("payload", {})
+        return attributes
 
     async def load_statistics(self, appliance: HonAppliance) -> Dict[str, Any]:
-        params: Dict = {
+        params: Dict[str, str] = {
             "macAddress": appliance.mac_address,
             "applianceType": appliance.appliance_type,
         }
         url: str = f"{const.API_URL}/commands/v1/statistics"
         async with self._hon.get(url, params=params) as response:
-            return (await response.json()).get("payload", {})
+            statistics: Dict[str, Any] = (await response.json()).get("payload", {})
+        return statistics
 
     async def load_maintenance(self, appliance: HonAppliance) -> Dict[str, Any]:
         url = f"{const.API_URL}/commands/v1/maintenance-cycle"
         params = {"macAddress": appliance.mac_address}
         async with self._hon.get(url, params=params) as response:
-            return (await response.json()).get("payload", {})
+            maintenance: Dict[str, Any] = (await response.json()).get("payload", {})
+        return maintenance
 
     async def send_command(
         self,
         appliance: HonAppliance,
         command: str,
-        parameters: Dict,
-        ancillary_parameters: Dict,
+        parameters: Dict[str, Any],
+        ancillary_parameters: Dict[str, Any],
     ) -> bool:
         now: str = datetime.utcnow().isoformat()
-        data: Dict = {
+        data: Dict[str, Any] = {
             "macAddress": appliance.mac_address,
             "timestamp": f"{now[:-3]}Z",
             "commandName": command,
@@ -190,7 +210,7 @@ class HonAPI:
         }
         url: str = f"{const.API_URL}/commands/v1/send"
         async with self._hon.post(url, json=data) as response:
-            json_data: Dict = await response.json()
+            json_data: Dict[str, Any] = await response.json()
             if json_data.get("payload", {}).get("resultCode") == "0":
                 return True
             _LOGGER.error(await response.text())
@@ -200,16 +220,15 @@ class HonAPI:
     async def appliance_configuration(self) -> Dict[str, Any]:
         url: str = f"{const.API_URL}/config/v1/program-list-rules"
         async with self._hon_anonymous.get(url) as response:
-            result: Dict = await response.json()
-            if result and (data := result.get("payload")):
-                return data
-        return {}
+            result: Dict[str, Any] = await response.json()
+        data: Dict[str, Any] = result.get("payload", {})
+        return data
 
     async def app_config(
         self, language: str = "en", beta: bool = True
     ) -> Dict[str, Any]:
         url: str = f"{const.API_URL}/app-config"
-        payload_data: Dict = {
+        payload_data: Dict[str, str | int] = {
             "languageCode": language,
             "beta": beta,
             "appVersion": const.APP_VERSION,
@@ -217,17 +236,17 @@ class HonAPI:
         }
         payload: str = json.dumps(payload_data, separators=(",", ":"))
         async with self._hon_anonymous.post(url, data=payload) as response:
-            if (result := await response.json()) and (data := result.get("payload")):
-                return data
-        return {}
+            result = await response.json()
+        data: Dict[str, Any] = result.get("payload", {})
+        return data
 
     async def translation_keys(self, language: str = "en") -> Dict[str, Any]:
         config = await self.app_config(language=language)
-        if url := config.get("language", {}).get("jsonPath"):
-            async with self._hon_anonymous.get(url) as response:
-                if result := await response.json():
-                    return result
-        return {}
+        if not (url := config.get("language", {}).get("jsonPath")):
+            return {}
+        async with self._hon_anonymous.get(url) as response:
+            result: Dict[str, Any] = await response.json()
+        return result
 
     async def close(self) -> None:
         if self._hon_handler is not None:
@@ -237,16 +256,24 @@ class HonAPI:
 
 
 class TestAPI(HonAPI):
-    def __init__(self, path):
+    def __init__(self, path: Path):
         super().__init__()
         self._anonymous = True
         self._path: Path = path
 
-    def _load_json(self, appliance: HonAppliance, file) -> Dict[str, Any]:
+    def _load_json(self, appliance: HonAppliance, file: str) -> Dict[str, Any]:
         directory = f"{appliance.appliance_type}_{appliance.appliance_model_id}".lower()
-        path = f"{self._path}/{directory}/{file}.json"
+        if not (path := self._path / directory / f"{file}.json").exists():
+            _LOGGER.warning("Can't open %s", str(path))
+            return {}
         with open(path, "r", encoding="utf-8") as json_file:
-            return json.loads(json_file.read())
+            text = json_file.read()
+        try:
+            data: Dict[str, Any] = json.loads(text)
+            return data
+        except json.decoder.JSONDecodeError as error:
+            _LOGGER.error("%s - %s", str(path), error)
+            return {}
 
     async def load_appliances(self) -> List[Dict[str, Any]]:
         result = []
@@ -288,7 +315,7 @@ class TestAPI(HonAPI):
         self,
         appliance: HonAppliance,
         command: str,
-        parameters: Dict,
-        ancillary_parameters: Dict,
+        parameters: Dict[str, Any],
+        ancillary_parameters: Dict[str, Any],
     ) -> bool:
         return True

pyhon/connection/auth.py

@@ -6,14 +6,16 @@ import urllib
 from contextlib import suppress
 from dataclasses import dataclass
 from datetime import datetime, timedelta
-from typing import Dict, Optional
+from typing import Dict, Optional, Any, List
 from urllib import parse
 from urllib.parse import quote
 
+import aiohttp
 from aiohttp import ClientResponse
 from yarl import URL
 
 from pyhon import const, exceptions
+from pyhon.connection.device import HonDevice
 from pyhon.connection.handler.auth import HonAuthConnectionHandler
 
 _LOGGER = logging.getLogger(__name__)
@@ -25,14 +27,20 @@ class HonLoginData:
     email: str = ""
     password: str = ""
     fw_uid: str = ""
-    loaded: Optional[Dict] = None
+    loaded: Optional[Dict[str, Any]] = None
 
 
 class HonAuth:
     _TOKEN_EXPIRES_AFTER_HOURS = 8
     _TOKEN_EXPIRE_WARNING_HOURS = 7
 
-    def __init__(self, session, email, password, device) -> None:
+    def __init__(
+        self,
+        session: aiohttp.ClientSession,
+        email: str,
+        password: str,
+        device: HonDevice,
+    ) -> None:
         self._session = session
         self._request = HonAuthConnectionHandler(session)
         self._login_data = HonLoginData()
@@ -107,7 +115,8 @@ class HonAuth:
         async with self._request.get(url) as response:
             text = await response.text()
             self._expires = datetime.utcnow()
-            if not (login_url := re.findall("url = '(.+?)'", text)):
+            login_url: List[str] = re.findall("url = '(.+?)'", text)
+            if not login_url:
                 if "oauth/done#access_token=" in text:
                     self._parse_token_data(text)
                     raise exceptions.HonNoAuthenticationNeeded()
@@ -120,7 +129,7 @@ class HonAuth:
                 await self._error_logger(response)
         return new_location
 
-    async def _handle_redirects(self, login_url) -> str:
+    async def _handle_redirects(self, login_url: str) -> str:
         redirect1 = await self._manual_redirect(login_url)
         redirect2 = await self._manual_redirect(redirect1)
         return f"{redirect2}&System=IoT_Mobile_App&RegistrationSubChannel=hOn"
@@ -176,7 +185,8 @@ class HonAuth:
             if response.status == 200:
                 with suppress(json.JSONDecodeError, KeyError):
                     result = await response.json()
-                    return result["events"][0]["attributes"]["values"]["url"]
+                    url: str = result["events"][0]["attributes"]["values"]["url"]
+                    return url
             await self._error_logger(response)
             return ""
 

pyhon/connection/device.py

@@ -32,12 +32,14 @@ class HonDevice:
     def mobile_id(self) -> str:
         return self._mobile_id
 
-    def get(self, mobile: bool = False) -> Dict:
-        result = {
+    def get(self, mobile: bool = False) -> Dict[str, str | int]:
+        result: Dict[str, str | int] = {
             "appVersion": self.app_version,
             "mobileId": self.mobile_id,
             "os": self.os,
             "osVersion": self.os_version,
             "deviceModel": self.device_model,
         }
-        return (result | {"mobileOs": result.pop("os")}) if mobile else result
+        if mobile:
+            result |= {"mobileOs": result.pop("os", "")}
+        return result

pyhon/connection/handler/anonym.py

@@ -1,21 +1,27 @@
 import logging
 from collections.abc import AsyncIterator
 from contextlib import asynccontextmanager
-from typing import Callable, Dict
+from typing import Dict, Any
+
+import aiohttp
+from yarl import URL
 
 from pyhon import const
 from pyhon.connection.handler.base import ConnectionHandler
+from pyhon.typedefs import Callback
 
 _LOGGER = logging.getLogger(__name__)
 
 
 class HonAnonymousConnectionHandler(ConnectionHandler):
-    _HEADERS: Dict = ConnectionHandler._HEADERS | {"x-api-key": const.API_KEY}
+    _HEADERS: Dict[str, str] = ConnectionHandler._HEADERS | {"x-api-key": const.API_KEY}
 
     @asynccontextmanager
-    async def _intercept(self, method: Callable, *args, **kwargs) -> AsyncIterator:
+    async def _intercept(
+        self, method: Callback, url: str | URL, *args: Any, **kwargs: Dict[str, Any]
+    ) -> AsyncIterator[aiohttp.ClientResponse]:
         kwargs["headers"] = kwargs.pop("headers", {}) | self._HEADERS
-        async with method(*args, **kwargs) as response:
+        async with method(url, *args, **kwargs) as response:
             if response.status == 403:
                 _LOGGER.error("Can't authenticate anymore")
             yield response

pyhon/connection/handler/auth.py

@@ -1,12 +1,14 @@
 import logging
 from collections.abc import AsyncIterator
 from contextlib import asynccontextmanager
-from typing import Optional, Callable, List, Tuple
+from typing import Optional, List, Tuple, Any, Dict
 
 import aiohttp
+from yarl import URL
 
 from pyhon import const
 from pyhon.connection.handler.base import ConnectionHandler
+from pyhon.typedefs import Callback
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -28,9 +30,9 @@ class HonAuthConnectionHandler(ConnectionHandler):
 
     @asynccontextmanager
     async def _intercept(
-        self, method: Callable, *args, loop: int = 0, **kwargs
-    ) -> AsyncIterator:
+        self, method: Callback, url: str | URL, *args: Any, **kwargs: Dict[str, Any]
+    ) -> AsyncIterator[aiohttp.ClientResponse]:
         kwargs["headers"] = kwargs.pop("headers", {}) | self._HEADERS
-        async with method(*args, **kwargs) as response:
-            self._called_urls.append((response.status, response.request_info.url))
+        async with method(url, *args, **kwargs) as response:
+            self._called_urls.append((response.status, str(response.request_info.url)))
             yield response

pyhon/connection/handler/base.py

@@ -1,18 +1,21 @@
 import logging
 from collections.abc import AsyncIterator
 from contextlib import asynccontextmanager
-from typing import Optional, Callable, Dict
+from types import TracebackType
+from typing import Optional, Dict, Type, Any, Protocol
 
 import aiohttp
 from typing_extensions import Self
+from yarl import URL
 
 from pyhon import const, exceptions
+from pyhon.typedefs import Callback
 
 _LOGGER = logging.getLogger(__name__)
 
 
 class ConnectionHandler:
-    _HEADERS: Dict = {
+    _HEADERS: Dict[str, str] = {
         "user-agent": const.USER_AGENT,
         "Content-Type": "application/json",
     }
@@ -24,32 +27,49 @@ class ConnectionHandler:
     async def __aenter__(self) -> Self:
         return await self.create()
 
-    async def __aexit__(self, exc_type, exc_val, exc_tb) -> None:
+    async def __aexit__(
+        self,
+        exc_type: Optional[Type[BaseException]],
+        exc: Optional[BaseException],
+        traceback: Optional[TracebackType],
+    ) -> None:
         await self.close()
 
+    @property
+    def session(self) -> aiohttp.ClientSession:
+        if self._session is None:
+            raise exceptions.NoSessionException
+        return self._session
+
     async def create(self) -> Self:
         if self._create_session:
             self._session = aiohttp.ClientSession()
         return self
 
     @asynccontextmanager
-    def _intercept(self, method: Callable, *args, loop: int = 0, **kwargs):
+    def _intercept(
+        self, method: Callback, url: str | URL, *args: Any, **kwargs: Dict[str, Any]
+    ) -> AsyncIterator[aiohttp.ClientResponse]:
         raise NotImplementedError
 
     @asynccontextmanager
-    async def get(self, *args, **kwargs) -> AsyncIterator[aiohttp.ClientResponse]:
+    async def get(
+        self, *args: Any, **kwargs: Any
+    ) -> AsyncIterator[aiohttp.ClientResponse]:
         if self._session is None:
             raise exceptions.NoSessionException()
         response: aiohttp.ClientResponse
-        async with self._intercept(self._session.get, *args, **kwargs) as response:
+        async with self._intercept(self._session.get, *args, **kwargs) as response:  # type: ignore[arg-type]
             yield response
 
     @asynccontextmanager
-    async def post(self, *args, **kwargs) -> AsyncIterator[aiohttp.ClientResponse]:
+    async def post(
+        self, *args: Any, **kwargs: Any
+    ) -> AsyncIterator[aiohttp.ClientResponse]:
         if self._session is None:
             raise exceptions.NoSessionException()
         response: aiohttp.ClientResponse
-        async with self._intercept(self._session.post, *args, **kwargs) as response:
+        async with self._intercept(self._session.post, *args, **kwargs) as response:  # type: ignore[arg-type]
             yield response
 
     async def close(self) -> None:

pyhon/connection/handler/hon.py

@@ -2,15 +2,17 @@ import json
 import logging
 from collections.abc import AsyncIterator
 from contextlib import asynccontextmanager
-from typing import Optional, Callable, Dict
+from typing import Optional, Dict, Any
 
 import aiohttp
 from typing_extensions import Self
+from yarl import URL
 
 from pyhon.connection.auth import HonAuth
 from pyhon.connection.device import HonDevice
 from pyhon.connection.handler.base import ConnectionHandler
 from pyhon.exceptions import HonAuthenticationError, NoAuthenticationException
+from pyhon.typedefs import Callback
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -41,10 +43,10 @@ class HonConnectionHandler(ConnectionHandler):
 
     async def create(self) -> Self:
         await super().create()
-        self._auth = HonAuth(self._session, self._email, self._password, self._device)
+        self._auth = HonAuth(self.session, self._email, self._password, self._device)
         return self
 
-    async def _check_headers(self, headers: Dict) -> Dict:
+    async def _check_headers(self, headers: Dict[str, str]) -> Dict[str, str]:
         if not (self.auth.cognito_token and self.auth.id_token):
             await self.auth.authenticate()
         headers["cognito-token"] = self.auth.cognito_token
@@ -53,17 +55,18 @@ class HonConnectionHandler(ConnectionHandler):
 
     @asynccontextmanager
     async def _intercept(
-        self, method: Callable, *args, loop: int = 0, **kwargs
-    ) -> AsyncIterator:
+        self, method: Callback, url: str | URL, *args: Any, **kwargs: Any
+    ) -> AsyncIterator[aiohttp.ClientResponse]:
+        loop: int = kwargs.pop("loop", 0)
         kwargs["headers"] = await self._check_headers(kwargs.get("headers", {}))
-        async with method(*args, **kwargs) as response:
+        async with method(url, *args, **kwargs) as response:
             if (
                 self.auth.token_expires_soon or response.status in [401, 403]
             ) and loop == 0:
                 _LOGGER.info("Try refreshing token...")
                 await self.auth.refresh()
                 async with self._intercept(
-                    method, *args, loop=loop + 1, **kwargs
+                    method, url, *args, loop=loop + 1, **kwargs
                 ) as result:
                     yield result
             elif (
@@ -77,7 +80,7 @@ class HonConnectionHandler(ConnectionHandler):
                 )
                 await self.create()
                 async with self._intercept(
-                    method, *args, loop=loop + 1, **kwargs
+                    method, url, *args, loop=loop + 1, **kwargs
                 ) as result:
                     yield result
             elif loop >= 2:

pyhon/const.py

@@ -4,7 +4,7 @@ API_KEY = "GRCqFhC6Gk@ikWXm1RmnSmX1cm,MxY-configuration"
 APP = "hon"
 # All seen id's (different accounts, different devices) are the same, so I guess this hash is static
 CLIENT_ID = "3MVG9QDx8IX8nP5T2Ha8ofvlmjLZl5L_gvfbT9.HJvpHGKoAS_dcMN8LYpTSYeVFCraUnV.2Ag1Ki7m4znVO6"
-APP_VERSION = "2.0.10"
+APP_VERSION = "2.1.2"
 OS_VERSION = 31
 OS = "android"
 DEVICE_MODEL = "exynos9820"

pyhon/diagnose.py

@@ -5,7 +5,7 @@ import shutil
 from pathlib import Path
 from typing import TYPE_CHECKING, List, Tuple
 
-from pyhon import helper
+from pyhon import printer
 
 if TYPE_CHECKING:
     from pyhon.appliance import HonAppliance
@@ -29,7 +29,7 @@ def anonymize_data(data: str) -> str:
         for match in re.findall(f'"{sensible}.*?":\\s"?(.+?)"?,?\\n', data):
             replace = re.sub("[a-z]", "x", match)
             replace = re.sub("[A-Z]", "X", replace)
-            replace = re.sub("\\d", "0", replace)
+            replace = re.sub("\\d", "1", replace)
             data = data.replace(match, replace)
     return data
 
@@ -38,7 +38,7 @@ async def load_data(appliance: "HonAppliance", topic: str) -> Tuple[str, str]:
     return topic, await getattr(appliance.api, f"load_{topic}")(appliance)
 
 
-def write_to_json(data: str, topic: str, path: Path, anonymous: bool = False):
+def write_to_json(data: str, topic: str, path: Path, anonymous: bool = False) -> Path:
     json_data = json.dumps(data, indent=4)
     if anonymous:
         json_data = anonymize_data(json_data)
@@ -65,15 +65,17 @@ async def appliance_data(
     return [write_to_json(data, topic, path, anonymous) for topic, data in api_data]
 
 
-async def zip_archive(appliance: "HonAppliance", path: Path, anonymous: bool = False):
+async def zip_archive(
+    appliance: "HonAppliance", path: Path, anonymous: bool = False
+) -> str:
     data = await appliance_data(appliance, path, anonymous)
     archive = data[0].parent
-    shutil.make_archive(str(archive.parent), "zip", archive)
+    shutil.make_archive(str(archive), "zip", archive)
     shutil.rmtree(archive)
     return f"{archive.stem}.zip"
 
 
-def yaml_export(appliance: "HonAppliance", anonymous=False) -> str:
+def yaml_export(appliance: "HonAppliance", anonymous: bool = False) -> str:
     data = {
         "attributes": appliance.attributes.copy(),
         "appliance": appliance.info,
@@ -87,12 +89,11 @@ def yaml_export(appliance: "HonAppliance", anonymous=False) -> str:
     if anonymous:
         for sensible in ["serialNumber", "coords"]:
             data.get("appliance", {}).pop(sensible, None)
-    data = {
-        "data": data,
-        "commands": helper.create_command(appliance.commands),
-        "rules": helper.create_rules(appliance.commands),
-    }
-    result = helper.pretty_print(data)
+    result = printer.pretty_print({"data": data})
+    if commands := printer.create_commands(appliance.commands):
+        result += printer.pretty_print({"commands": commands})
+    if rules := printer.create_rules(appliance.commands):
+        result += printer.pretty_print({"rules": rules})
     if anonymous:
         result = anonymize_data(result)
     return result

pyhon/helper.py

@@ -1,80 +1,3 @@
-def key_print(data, key="", start=True):
-    result = ""
-    if isinstance(data, list):
-        for i, value in enumerate(data):
-            result += key_print(value, key=f"{key}.{i}", start=False)
-    elif isinstance(data, dict):
-        for k, value in sorted(data.items()):
-            result += key_print(value, key=k if start else f"{key}.{k}", start=False)
-    else:
-        result += f"{key}: {data}\n"
-    return result
-
-
-# yaml.dump() would be done the same, but needs an additional dependency...
-def pretty_print(data, key="", intend=0, is_list=False, whitespace="  "):
-    result = ""
-    if isinstance(data, list):
-        if key:
-            result += f"{whitespace * intend}{'- ' if is_list else ''}{key}:\n"
-            intend += 1
-        for i, value in enumerate(data):
-            result += pretty_print(
-                value, intend=intend, is_list=True, whitespace=whitespace
-            )
-    elif isinstance(data, dict):
-        if key:
-            result += f"{whitespace * intend}{'- ' if is_list else ''}{key}:\n"
-            intend += 1
-        for i, (key, value) in enumerate(sorted(data.items())):
-            if is_list and not i:
-                result += pretty_print(
-                    value, key=key, intend=intend, is_list=True, whitespace=whitespace
-                )
-            elif is_list:
-                result += pretty_print(
-                    value, key=key, intend=intend + 1, whitespace=whitespace
-                )
-            else:
-                result += pretty_print(
-                    value, key=key, intend=intend, whitespace=whitespace
-                )
-    else:
-        result += f"{whitespace * intend}{'- ' if is_list else ''}{key}{': ' if key else ''}{data}\n"
-    return result
-
-
-def create_command(commands, concat=False):
-    result = {}
-    for name, command in commands.items():
-        for parameter, data in command.available_settings.items():
-            if data.typology == "enum":
-                value = data.values
-            elif data.typology == "range":
-                value = {"min": data.min, "max": data.max, "step": data.step}
-            else:
-                continue
-            if not concat:
-                result.setdefault(name, {})[parameter] = value
-            else:
-                result[f"{name}.{parameter}"] = value
-    return result
-
-
-def create_rules(commands, concat=False):
-    result = {}
-    for name, command in commands.items():
-        for parameter, data in command.available_settings.items():
-            value = data.triggers
-            if not value:
-                continue
-            if not concat:
-                result.setdefault(name, {})[parameter] = value
-            else:
-                result[f"{name}.{parameter}"] = value
-    return result
-
-
 def str_to_float(string: str | float) -> float:
     try:
         return int(string)

pyhon/hon.py

@@ -70,11 +70,11 @@ class Hon:
         return self._appliances
 
     @appliances.setter
-    def appliances(self, appliances) -> None:
+    def appliances(self, appliances: List[HonAppliance]) -> None:
         self._appliances = appliances
 
     async def _create_appliance(
-        self, appliance_data: Dict[str, Any], api: HonAPI, zone=0
+        self, appliance_data: Dict[str, Any], api: HonAPI, zone: int = 0
     ) -> None:
         appliance = HonAppliance(api, appliance_data, zone=zone)
         if appliance.mac_address == "":

pyhon/parameter/base.py

@@ -12,7 +12,9 @@ class HonParameter:
         self._mandatory: int = attributes.get("mandatory", 0)
         self._value: str | float = ""
         self._group: str = group
-        self._triggers: Dict[str, List[Tuple[Callable, "HonRule"]]] = {}
+        self._triggers: Dict[
+            str, List[Tuple[Callable[["HonRule"], None], "HonRule"]]
+        ] = {}
 
     @property
     def key(self) -> str:
@@ -51,20 +53,22 @@ class HonParameter:
     def group(self) -> str:
         return self._group
 
-    def add_trigger(self, value, func, data):
+    def add_trigger(
+        self, value: str, func: Callable[["HonRule"], None], data: "HonRule"
+    ) -> None:
         if self._value == value:
             func(data)
         self._triggers.setdefault(value, []).append((func, data))
 
-    def check_trigger(self, value) -> None:
+    def check_trigger(self, value: str | float) -> None:
         if str(value) in self._triggers:
             for trigger in self._triggers[str(value)]:
                 func, args = trigger
                 func(args)
 
     @property
-    def triggers(self):
-        result = {}
+    def triggers(self) -> Dict[str, Any]:
+        result: Dict[str, Any] = {}
         for value, rules in self._triggers.items():
             for _, rule in rules:
                 if rule.extras:

pyhon/parameter/enum.py

@@ -3,7 +3,7 @@ from typing import Dict, Any, List
 from pyhon.parameter.base import HonParameter
 
 
-def clean_value(value):
+def clean_value(value: str | float) -> str:
     return str(value).strip("[]").replace("|", "_").lower()
 
 
@@ -24,7 +24,7 @@ class HonParameterEnum(HonParameter):
         return [clean_value(value) for value in self._values]
 
     @values.setter
-    def values(self, values) -> None:
+    def values(self, values: List[str]) -> None:
         self._values = values
 
     @property
@@ -41,4 +41,4 @@ class HonParameterEnum(HonParameter):
             self._value = value
             self.check_trigger(value)
         else:
-            raise ValueError(f"Allowed values {self._values}")
+            raise ValueError(f"Allowed values: {self._values} But was: {value}")

pyhon/parameter/program.py

@@ -28,7 +28,7 @@ class HonParameterProgram(HonParameterEnum):
         if value in self.values:
             self._command.category = value
         else:
-            raise ValueError(f"Allowed values {self.values}")
+            raise ValueError(f"Allowed values: {self.values} But was: {value}")
 
     @property
     def values(self) -> List[str]:
@@ -36,7 +36,7 @@ class HonParameterProgram(HonParameterEnum):
         return sorted(values)
 
     @values.setter
-    def values(self, values) -> None:
+    def values(self, values: List[str]) -> None:
         return
 
     @property
@@ -50,5 +50,5 @@ class HonParameterProgram(HonParameterEnum):
         }
         return dict(sorted(values.items()))
 
-    def set_value(self, value: str):
+    def set_value(self, value: str) -> None:
         self._value = value

pyhon/parameter/range.py

@@ -13,7 +13,7 @@ class HonParameterRange(HonParameter):
         self._default: float = str_to_float(attributes.get("defaultValue", self.min))
         self._value: float = self._default
 
-    def __repr__(self):
+    def __repr__(self) -> str:
         return f"{self.__class__} (<{self.key}> [{self.min} - {self.max}])"
 
     @property
@@ -49,11 +49,15 @@ class HonParameterRange(HonParameter):
     @value.setter
     def value(self, value: str | float) -> None:
         value = str_to_float(value)
-        if self.min <= value <= self.max and not (value - self.min) % self.step:
+        if self.min <= value <= self.max and not ((value - self.min) * 100) % (
+            self.step * 100
+        ):
             self._value = value
             self.check_trigger(value)
         else:
-            raise ValueError(f"Allowed: min {self.min} max {self.max} step {self.step}")
+            raise ValueError(
+                f"Allowed: min {self.min} max {self.max} step {self.step} But was: {value}"
+            )
 
     @property
     def values(self) -> List[str]:

pyhon/printer.py

@@ -0,0 +1,94 @@
+from typing import Dict, Any, TYPE_CHECKING, List
+
+from pyhon.parameter.enum import HonParameterEnum
+from pyhon.parameter.range import HonParameterRange
+
+if TYPE_CHECKING:
+    from pyhon.commands import HonCommand
+
+
+def key_print(data: Any, key: str = "", start: bool = True) -> str:
+    result = ""
+    if isinstance(data, list):
+        for i, value in enumerate(data):
+            result += key_print(value, key=f"{key}.{i}", start=False)
+    elif isinstance(data, dict):
+        for k, value in sorted(data.items()):
+            result += key_print(value, key=k if start else f"{key}.{k}", start=False)
+    else:
+        result += f"{key}: {data}\n"
+    return result
+
+
+# yaml.dump() would be done the same, but needs an additional dependency...
+def pretty_print(
+    data: Any,
+    key: str = "",
+    intend: int = 0,
+    is_list: bool = False,
+    whitespace: str = "  ",
+) -> str:
+    result = ""
+    if isinstance(data, list):
+        if key:
+            result += f"{whitespace * intend}{'- ' if is_list else ''}{key}:\n"
+            intend += 1
+        for i, value in enumerate(data):
+            result += pretty_print(
+                value, intend=intend, is_list=True, whitespace=whitespace
+            )
+    elif isinstance(data, dict):
+        if key:
+            result += f"{whitespace * intend}{'- ' if is_list else ''}{key}:\n"
+            intend += 1
+        for i, (key, value) in enumerate(sorted(data.items())):
+            if is_list and not i:
+                result += pretty_print(
+                    value, key=key, intend=intend, is_list=True, whitespace=whitespace
+                )
+            elif is_list:
+                result += pretty_print(
+                    value, key=key, intend=intend + 1, whitespace=whitespace
+                )
+            else:
+                result += pretty_print(
+                    value, key=key, intend=intend, whitespace=whitespace
+                )
+    else:
+        result += f"{whitespace * intend}{'- ' if is_list else ''}{key}{': ' if key else ''}{data}\n"
+    return result
+
+
+def create_commands(
+    commands: Dict[str, "HonCommand"], concat: bool = False
+) -> Dict[str, Any]:
+    result: Dict[str, Any] = {}
+    for name, command in commands.items():
+        for parameter, data in command.available_settings.items():
+            if isinstance(data, HonParameterEnum):
+                value: List[str] | Dict[str, str | float] = data.values
+            elif isinstance(data, HonParameterRange):
+                value = {"min": data.min, "max": data.max, "step": data.step}
+            else:
+                continue
+            if not concat:
+                result.setdefault(name, {})[parameter] = value
+            else:
+                result[f"{name}.{parameter}"] = value
+    return result
+
+
+def create_rules(
+    commands: Dict[str, "HonCommand"], concat: bool = False
+) -> Dict[str, Any]:
+    result: Dict[str, Any] = {}
+    for name, command in commands.items():
+        for parameter, data in command.available_settings.items():
+            value = data.triggers
+            if not value:
+                continue
+            if not concat:
+                result.setdefault(name, {})[parameter] = value
+            else:
+                result[f"{name}.{parameter}"] = value
+    return result

pyhon/rules.py

@@ -6,6 +6,7 @@ from pyhon.parameter.range import HonParameterRange
 
 if TYPE_CHECKING:
     from pyhon.commands import HonCommand
+    from pyhon.parameter.base import HonParameter
 
 
 @dataclass
@@ -18,18 +19,24 @@ class HonRule:
 
 
 class HonRuleSet:
-    def __init__(self, command: "HonCommand", rule):
+    def __init__(self, command: "HonCommand", rule: Dict[str, Any]):
         self._command: "HonCommand" = command
         self._rules: Dict[str, List[HonRule]] = {}
         self._parse_rule(rule)
 
-    def _parse_rule(self, rule):
+    def _parse_rule(self, rule: Dict[str, Any]) -> None:
         for param_key, params in rule.items():
             param_key = self._command.appliance.options.get(param_key, param_key)
             for trigger_key, trigger_data in params.items():
                 self._parse_conditions(param_key, trigger_key, trigger_data)
 
-    def _parse_conditions(self, param_key, trigger_key, trigger_data, extra=None):
+    def _parse_conditions(
+        self,
+        param_key: str,
+        trigger_key: str,
+        trigger_data: Dict[str, Any],
+        extra: Optional[Dict[str, str]] = None,
+    ) -> None:
         trigger_key = trigger_key.replace("@", "")
         trigger_key = self._command.appliance.options.get(trigger_key, trigger_key)
         for multi_trigger_value, param_data in trigger_data.items():
@@ -46,16 +53,21 @@ class HonRuleSet:
                         self._parse_conditions(param_key, extra_key, extra_data, extra)
 
     def _create_rule(
-        self, param_key, trigger_key, trigger_value, param_data, extras=None
-    ):
+        self,
+        param_key: str,
+        trigger_key: str,
+        trigger_value: str,
+        param_data: Dict[str, Any],
+        extras: Optional[Dict[str, str]] = None,
+    ) -> None:
         if param_data.get("fixedValue") == f"@{param_key}":
             return
         self._rules.setdefault(trigger_key, []).append(
             HonRule(trigger_key, trigger_value, param_key, param_data, extras)
         )
 
-    def _duplicate_for_extra_conditions(self):
-        new = {}
+    def _duplicate_for_extra_conditions(self) -> None:
+        new: Dict[str, List[HonRule]] = {}
         for rules in self._rules.values():
             for rule in rules:
                 if rule.extras is None:
@@ -71,8 +83,8 @@ class HonRuleSet:
             for rule in rules:
                 self._rules.setdefault(key, []).append(rule)
 
-    def _add_trigger(self, parameter, data):
-        def apply(rule: HonRule):
+    def _add_trigger(self, parameter: "HonParameter", data: HonRule) -> None:
+        def apply(rule: HonRule) -> None:
             if rule.extras is not None:
                 for key, value in rule.extras.items():
                     if str(self._command.parameters.get(key)) != str(value):
@@ -96,10 +108,10 @@ class HonRuleSet:
 
         parameter.add_trigger(data.trigger_value, apply, data)
 
-    def patch(self):
+    def patch(self) -> None:
         self._duplicate_for_extra_conditions()
         for name, parameter in self._command.parameters.items():
             if name not in self._rules:
                 continue
-            for data in self._rules.get(name):
+            for data in self._rules.get(name, []):
                 self._add_trigger(parameter, data)

pyhon/typedefs.py

@@ -0,0 +1,27 @@
+from typing import Union, Any, TYPE_CHECKING, Protocol
+
+import aiohttp
+from yarl import URL
+
+if TYPE_CHECKING:
+    from pyhon.parameter.base import HonParameter
+    from pyhon.parameter.enum import HonParameterEnum
+    from pyhon.parameter.fixed import HonParameterFixed
+    from pyhon.parameter.program import HonParameterProgram
+    from pyhon.parameter.range import HonParameterRange
+
+
+class Callback(Protocol):
+    def __call__(
+        self, url: str | URL, *args: Any, **kwargs: Any
+    ) -> aiohttp.client._RequestContextManager:
+        ...
+
+
+Parameter = Union[
+    "HonParameter",
+    "HonParameterRange",
+    "HonParameterEnum",
+    "HonParameterFixed",
+    "HonParameterProgram",
+]

requirements.txt

@@ -1,2 +1,3 @@
-aiohttp==3.8.4
-yarl==1.8.2
+aiohttp~=3.8.5
+yarl~=1.9.2
+typing-extensions~=4.7.1

setup.py

@@ -7,7 +7,7 @@ with open("README.md", "r") as f:
 
 setup(
     name="pyhOn",
-    version="0.14.2",
+    version="0.14.12",
     author="Andre Basche",
     description="Control hOn devices with python",
     long_description=long_description,
@@ -21,7 +21,7 @@ setup(
     packages=find_packages(),
     include_package_data=True,
     python_requires=">=3.10",
-    install_requires=["aiohttp"],
+    install_requires=["aiohttp~=3.8.5", "typing-extensions~=4.7.1", "yarl~=1.9.2"],
     classifiers=[
         "Development Status :: 4 - Beta",
         "Environment :: Console",