Use parameter optional

pyhon/appliance.py

@@ -1,4 +1,5 @@
 import importlib
+import logging
 from contextlib import suppress
 from typing import Optional, Dict, Any
 from typing import TYPE_CHECKING
@@ -11,6 +12,9 @@ if TYPE_CHECKING:
     from pyhon import HonAPI
 
 
+_LOGGER = logging.getLogger(__name__)
+
+
 class HonAppliance:
     def __init__(
         self, api: Optional["HonAPI"], info: Dict[str, Any], zone: int = 0
@@ -183,7 +187,10 @@ class HonAppliance:
 
     async def load_attributes(self):
         self._attributes = await self._api.load_attributes(self)
-        for name, values in self._attributes.pop("shadow").get("parameters").items():
+        _LOGGER.warning(self._attributes)
+        for name, values in (
+            self._attributes.pop("shadow", {}).get("parameters", {}).items()
+        ):
             self._attributes.setdefault("parameters", {})[name] = values["parNewVal"]
 
     async def load_statistics(self):

pyhon/commands.py

@@ -89,8 +89,6 @@ class HonCommand:
         for key, parameter in (
             command._parameters | command._ancillary_parameters
         ).items():
-            if isinstance(parameter, HonParameterFixed):
-                continue
             if key not in keys:
                 keys.append(key)
         return keys
@@ -108,7 +106,6 @@ class HonCommand:
 
     @property
     def settings(self) -> Dict[str, HonParameter]:
-        """Parameters with typology enum and range"""
         return {
             s: param
             for s in self.setting_keys

pyhon/connection/api.py

@@ -12,7 +12,7 @@ from pyhon.connection.auth import HonAuth
 from pyhon.connection.handler.anonym import HonAnonymousConnectionHandler
 from pyhon.connection.handler.hon import HonConnectionHandler
 
-_LOGGER = logging.getLogger()
+_LOGGER = logging.getLogger(__name__)
 
 
 class HonAPI:
@@ -75,13 +75,14 @@ class HonAPI:
             "code": appliance.info["code"],
             "applianceModelId": appliance.appliance_model_id,
             "macAddress": appliance.mac_address,
-            "fwVersion": appliance.info["fwVersion"],
             "os": const.OS,
             "appVersion": const.APP_VERSION,
             "series": appliance.info["series"],
         }
         if firmware_id := appliance.info.get("eepromId"):
             params["firmwareId"] = firmware_id
+        if firmware_version := appliance.info.get("fwVersion"):
+            params["fwVersion"] = firmware_version
         url: str = f"{const.API_URL}/commands/v1/retrieve"
         async with self._hon.get(url, params=params) as response:
             result: Dict = (await response.json()).get("payload", {})

setup.py

@@ -7,7 +7,7 @@ with open("README.md", "r") as f:
 
 setup(
     name="pyhOn",
-    version="0.8.3",
+    version="0.8.6",
     author="Andre Basche",
     description="Control hOn devices with python",
     long_description=long_description,